From bbac247f2ca0039948ce4137799bbac899653de1 Mon Sep 17 00:00:00 2001
From: Miguel Palau Zarza <mpalauzarza@gmail.com>
Date: Tue, 29 Jul 2025 15:03:58 -0600
Subject: [PATCH] refactor: use DataSourceConfigErrorStatus extension point for
 troubleshooting guide

Use the specific DataSourceConfigErrorStatus extension point instead of
DataSourceConfigStatus with conditional logic in configure function.
This simplifies the code by leveraging the right abstraction level.
---
 .../extensions/getDataSourceExtensionConfigs.tsx    | 13 +++----------
 1 file changed, 3 insertions(+), 10 deletions(-)

diff --git a/public/app/features/datasources/extensions/getDataSourceExtensionConfigs.tsx b/public/app/features/datasources/extensions/getDataSourceExtensionConfigs.tsx
index 13996c249c0..60f7b6908ec 100644
--- a/public/app/features/datasources/extensions/getDataSourceExtensionConfigs.tsx
+++ b/public/app/features/datasources/extensions/getDataSourceExtensionConfigs.tsx
@@ -2,7 +2,7 @@ import {
   PluginExtensionAddedLinkConfig,
   PluginExtensionPoints,
   PluginExtensionDataSourceConfigActionsContext,
-  PluginExtensionDataSourceConfigStatusContext,
+  DataSourceConfigErrorStatusContext,
 } from '@grafana/data';
 
 import { createAddedLinkConfig } from '../../plugins/extensions/utils';
@@ -35,23 +35,16 @@ export function getDataSourceExtensionConfigs(): PluginExtensionAddedLinkConfig[
       }),
 
       // Example: Add troubleshooting link for error status
-      createAddedLinkConfig<PluginExtensionDataSourceConfigStatusContext>({
+      createAddedLinkConfig<DataSourceConfigErrorStatusContext>({
         // This is called at the top level, so will break if we add a translation here 😱
         // eslint-disable-next-line @grafana/i18n/no-untranslated-strings
         title: 'Troubleshooting Guide',
         // eslint-disable-next-line @grafana/i18n/no-untranslated-strings
         description: 'Get help resolving this datasource issue',
-        targets: [PluginExtensionPoints.DataSourceConfigStatus],
+        targets: [PluginExtensionPoints.DataSourceConfigErrorStatus],
         icon: 'question-circle',
         // eslint-disable-next-line @grafana/i18n/no-untranslated-strings
         category: 'Help',
-        configure: (context) => {
-          // Only show for error status
-          if (context?.severity !== 'error') {
-            return undefined;
-          }
-          return {};
-        },
         path: '/a/grafana/docs/troubleshooting/datasources',
       }),
     ];