public/grafana
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Alerting: Improve test coverage for ConditionsCmd (#58603)

Browse Source
This commit is contained in:
George Robinson
2022-11-11 09:27:35 +00:00
committed by GitHub
parent c090de9ed9
commit bd87b46b15
4 changed files with 514 additions and 330 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkg/expr/classic/evaluator_test.go
+14 -14
View File
@@ -18,25 +18,25 @@ func TestThresholdEvaluator(t *testing.T) {
{
name: "value 3 is gt 1: true",
evaluator: &thresholdEvaluator{"gt", 1},
inputNumber: valBasedNumber(ptr.Float64(3)),
inputNumber: newNumber(ptr.Float64(3)),
expected: true,
},
{
name: "value 1 is gt 3: false",
evaluator: &thresholdEvaluator{"gt", 3},
inputNumber: valBasedNumber(ptr.Float64(1)),
inputNumber: newNumber(ptr.Float64(1)),
expected: false,
},
{
name: "value 3 is lt 1: true",
evaluator: &thresholdEvaluator{"lt", 1},
inputNumber: valBasedNumber(ptr.Float64(3)),
inputNumber: newNumber(ptr.Float64(3)),
expected: false,
},
{
name: "value 1 is lt 3: false",
evaluator: &thresholdEvaluator{"lt", 3},
inputNumber: valBasedNumber(ptr.Float64(1)),
inputNumber: newNumber(ptr.Float64(1)),
expected: true,
},
}
@@ -59,50 +59,50 @@ func TestRangedEvaluator(t *testing.T) {
{
name: "value 3 is within range 1, 100: true",
evaluator: &rangedEvaluator{"within_range", 1, 100},
inputNumber: valBasedNumber(ptr.Float64(3)),
inputNumber: newNumber(ptr.Float64(3)),
expected: true,
},
{
name: "value 300 is within range 1, 100: false",
evaluator: &rangedEvaluator{"within_range", 1, 100},
inputNumber: valBasedNumber(ptr.Float64(300)),
inputNumber: newNumber(ptr.Float64(300)),
expected: false,
},
{
name: "value 3 is within range 100, 1: true",
evaluator: &rangedEvaluator{"within_range", 100, 1},
inputNumber: valBasedNumber(ptr.Float64(3)),
inputNumber: newNumber(ptr.Float64(3)),
expected: true,
},
{
name: "value 300 is within range 100, 1: false",
evaluator: &rangedEvaluator{"within_range", 100, 1},
inputNumber: valBasedNumber(ptr.Float64(300)),
inputNumber: newNumber(ptr.Float64(300)),
expected: false,
},
// outside
{
name: "value 1000 is outside range 1, 100: true",
evaluator: &rangedEvaluator{"outside_range", 1, 100},
inputNumber: valBasedNumber(ptr.Float64(1000)),
inputNumber: newNumber(ptr.Float64(1000)),
expected: true,
},
{
name: "value 50 is outside range 1, 100: false",
evaluator: &rangedEvaluator{"outside_range", 1, 100},
inputNumber: valBasedNumber(ptr.Float64(50)),
inputNumber: newNumber(ptr.Float64(50)),
expected: false,
},
{
name: "value 1000 is outside range 100, 1: true",
evaluator: &rangedEvaluator{"outside_range", 100, 1},
inputNumber: valBasedNumber(ptr.Float64(1000)),
inputNumber: newNumber(ptr.Float64(1000)),
expected: true,
},
{
name: "value 50 is outside range 100, 1: false",
evaluator: &rangedEvaluator{"outside_range", 100, 1},
inputNumber: valBasedNumber(ptr.Float64(50)),
inputNumber: newNumber(ptr.Float64(50)),
expected: false,
},
}
@@ -124,13 +124,13 @@ func TestNoValueEvaluator(t *testing.T) {
{
name: "value 50 is no_value: false",
evaluator: &noValueEvaluator{},
inputNumber: valBasedNumber(ptr.Float64(50)),
inputNumber: newNumber(ptr.Float64(50)),
expected: false,
},
{
name: "value nil is no_value: true",
evaluator: &noValueEvaluator{},
inputNumber: valBasedNumber(nil),
inputNumber: newNumber(nil),
expected: true,
},
}