Remove unnecesary joins from queries (#43626)

2022-01-04 13:04:02 +01:00
parent 8ee53347bf
commit bdbd199910
2 changed files with 3 additions and 7 deletions
@@ -51,17 +51,15 @@ func (sb *SQLBuilder) WriteDashboardPermissionFilter(user *models.SignedInUser,
 			SELECT distinct DashboardId from (
 				SELECT d.id AS DashboardId
 					FROM dashboard AS d
-					LEFT JOIN dashboard AS folder on folder.id = d.folder_id
 					LEFT JOIN dashboard_acl AS da ON
 						da.dashboard_id = d.id OR
 						da.dashboard_id = d.folder_id
-					LEFT JOIN team_member as ugm on ugm.team_id = da.team_id
 					WHERE
 						d.org_id = ? AND
 						da.permission >= ? AND
 						(
 							da.user_id = ? OR
-							ugm.user_id = ? OR
+							da.team_id IN (SELECT team_id from team_member AS tm WHERE tm.user_id = ?) OR
 							da.role IN (?` + strings.Repeat(",?", len(okRoles)-1) + `)
 						)
 				UNION