public/grafana
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

CloudMigration: Fix flakey test (#111126)

Browse Source 
* fix flakey test

* remove skip

* change require
This commit is contained in:
Lucy Chen
2025-09-16 08:39:14 -04:00
committed by GitHub
parent 35df3ae554
commit be9ce8a5ff
1 changed files with 9 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkg/services/cloudmigration/cloudmigrationimpl/cloudmigration_test.go
+9 -8
View File
@@ -85,9 +85,6 @@ func Test_CreateGetAndDeleteToken(t *testing.T) {
}
func Test_GetSnapshotStatusFromGMS(t *testing.T) {
// Skipped until flakiness is fixed
t.Skip()
t.Parallel()
setupTest := func(ctx context.Context) (service *Service, snapshotUID string, sessionUID string) {
@@ -179,7 +176,7 @@ func Test_GetSnapshotStatusFromGMS(t *testing.T) {
})
require.NoError(t, err)
require.Eventually(t, checkStatusSync(ctx, s, snapshotUID, sessionUID, cloudmigration.SnapshotStatusPendingProcessing), time.Second, 10*time.Millisecond)
require.True(t, gmsClientFake.GetSnapshotStatusCallCount() >= 1)
require.Eventually(t, gmsClientFake.ValidateSnapshotStatusCallCount, time.Second, 10*time.Millisecond)
})
t.Run("test case: gms snapshot processing", func(t *testing.T) {
@@ -203,7 +200,7 @@ func Test_GetSnapshotStatusFromGMS(t *testing.T) {
})
require.NoError(t, err)
require.Eventually(t, checkStatusSync(ctx, s, snapshotUID, sessionUID, cloudmigration.SnapshotStatusProcessing), time.Second, 10*time.Millisecond)
require.True(t, gmsClientFake.GetSnapshotStatusCallCount() >= 1)
require.Eventually(t, gmsClientFake.ValidateSnapshotStatusCallCount, time.Second, 10*time.Millisecond)
})
t.Run("test case: gms snapshot finished", func(t *testing.T) {
@@ -227,7 +224,7 @@ func Test_GetSnapshotStatusFromGMS(t *testing.T) {
})
require.NoError(t, err)
require.Eventually(t, checkStatusSync(ctx, s, snapshotUID, sessionUID, cloudmigration.SnapshotStatusFinished), time.Second, 10*time.Millisecond)
require.True(t, gmsClientFake.GetSnapshotStatusCallCount() >= 1)
require.Eventually(t, gmsClientFake.ValidateSnapshotStatusCallCount, time.Second, 10*time.Millisecond)
})
t.Run("test case: gms snapshot canceled", func(t *testing.T) {
@@ -251,7 +248,7 @@ func Test_GetSnapshotStatusFromGMS(t *testing.T) {
})
require.NoError(t, err)
require.Eventually(t, checkStatusSync(ctx, s, snapshotUID, sessionUID, cloudmigration.SnapshotStatusCanceled), time.Second, 10*time.Millisecond)
require.True(t, gmsClientFake.GetSnapshotStatusCallCount() >= 1)
require.Eventually(t, gmsClientFake.ValidateSnapshotStatusCallCount, time.Second, 10*time.Millisecond)
})
t.Run("test case: gms snapshot error", func(t *testing.T) {
@@ -275,7 +272,7 @@ func Test_GetSnapshotStatusFromGMS(t *testing.T) {
})
require.NoError(t, err)
require.Eventually(t, checkStatusSync(ctx, s, snapshotUID, sessionUID, cloudmigration.SnapshotStatusError), time.Second, 10*time.Millisecond)
assert.True(t, gmsClientFake.GetSnapshotStatusCallCount() >= 1)
require.Eventually(t, gmsClientFake.ValidateSnapshotStatusCallCount, time.Second, 10*time.Millisecond)
})
t.Run("test case: gms snapshot unknown", func(t *testing.T) {
@@ -1064,3 +1061,7 @@ func (m *gmsClientMock) GetSnapshotStatusCallCount() int {
return m.getStatusCalled
}
func (m *gmsClientMock) ValidateSnapshotStatusCallCount() bool {
return m.GetSnapshotStatusCallCount() >= 1
}