Correlations: Add legacy storage (#112038)

pkg/tests/api/correlations/correlations_read_test.go

@@ -109,7 +109,7 @@ func TestIntegrationReadCorrelation(t *testing.T) {
 	var created int64 = 0
 	err := ctx.env.SQLStore.WithDbSession(context.Background(), func(sess *db.Session) error {
 		var innerError error
-		created, innerError = sess.InsertMulti(&[]correlations.Correlation{
+		created, innerError = sess.Omit("source_type", "target_type").InsertMulti(&[]correlations.Correlation{
 			{
 				UID:       "uid-1",
 				SourceUID: dsWithoutCorrelations.UID,

pkg/tests/apis/correlations/correlations_test.go

@@ -0,0 +1,113 @@
+package correlations
+
+import (
+	"context"
+	"encoding/json"
+	"fmt"
+	"net/http"
+	"testing"
+
+	"github.com/stretchr/testify/require"
+	v1 "k8s.io/apimachinery/pkg/apis/meta/v1"
+	"k8s.io/utils/ptr"
+
+	correlationsV0 "github.com/grafana/grafana/apps/correlations/pkg/apis/correlation/v0alpha1"
+	grafanarest "github.com/grafana/grafana/pkg/apiserver/rest"
+	"github.com/grafana/grafana/pkg/services/correlations"
+	"github.com/grafana/grafana/pkg/services/datasources"
+	"github.com/grafana/grafana/pkg/services/featuremgmt"
+	"github.com/grafana/grafana/pkg/setting"
+	"github.com/grafana/grafana/pkg/tests/apis"
+	"github.com/grafana/grafana/pkg/tests/testinfra"
+	"github.com/grafana/grafana/pkg/tests/testsuite"
+	"github.com/grafana/grafana/pkg/util/testutil"
+)
+
+func TestMain(m *testing.M) {
+	testsuite.Run(m)
+}
+
+func TestIntegrationCorrelations(t *testing.T) {
+	testutil.SkipIntegrationTestInShortMode(t)
+
+	for _, mode := range []grafanarest.DualWriterMode{
+		grafanarest.Mode0, // Only legacy for now
+		// grafanarest.Mode2,
+		// grafanarest.Mode3,
+		// grafanarest.Mode5,
+	} {
+		t.Run(fmt.Sprintf("correlations (mode:%d)", mode), func(t *testing.T) {
+			helper := apis.NewK8sTestHelper(t, testinfra.GrafanaOpts{
+				DisableAnonymous:     true,
+				EnableFeatureToggles: []string{featuremgmt.FlagKubernetesCorrelations},
+				UnifiedStorageConfig: map[string]setting.UnifiedStorageConfig{
+					"correlation.correlations.grafana.app": {
+						DualWriterMode: mode,
+					},
+				},
+			})
+			helper.CreateDS(&datasources.AddDataSourceCommand{
+				OrgID: helper.Org1.OrgID,
+				Name:  "test-A",
+				UID:   "test-A",
+				Type:  "testdata",
+			})
+			helper.CreateDS(&datasources.AddDataSourceCommand{
+				OrgID: helper.Org1.OrgID,
+				Name:  "test-B",
+				UID:   "test-B",
+				Type:  "testdata",
+			})
+
+			ctx := context.Background()
+			kind := correlationsV0.CorrelationKind()
+			correlationsClient := helper.GetResourceClient(apis.ResourceClientArgs{
+				User: helper.Org1.Admin,
+				GVR:  kind.GroupVersionResource(),
+			})
+
+			cmd := &correlations.CreateCorrelationCommand{
+				// Loaded from the request, not the payload
+				// SourceUID:   "test-A",
+				// OrgId:       correlationsClient.Args.User.Identity.GetOrgID(),
+				TargetUID:   ptr.To("test-B"),
+				Label:       "hello",
+				Description: "test test test",
+				Type:        correlations.CorrelationType("query"),
+				Config: correlations.CorrelationConfig{
+					Field:  "a",
+					Target: map[string]any{},
+					Transformations: correlations.Transformations{{
+						Type:       "logfmt",
+						Expression: "aaaa",
+						Field:      "f0",
+						MapValue:   "mapped",
+					}},
+				},
+			}
+			body, err := json.Marshal(cmd)
+			require.NoError(t, err)
+
+			createAtoB := apis.DoRequest(helper, apis.RequestParams{
+				User:   correlationsClient.Args.User,
+				Method: http.MethodPost,
+				Path:   "/api/datasources/uid/test-A/correlations",
+				Body:   body,
+			}, &correlations.CreateCorrelationResponseBody{})
+			require.Equal(t, http.StatusOK, createAtoB.Response.StatusCode, "create correlation")
+			require.NotEmpty(t, createAtoB.Result.Result.UID, "a to b")
+			uidAtoB := createAtoB.Result.Result.UID
+
+			// List the value
+			listResults, err := correlationsClient.Resource.List(ctx, v1.ListOptions{})
+			require.NoError(t, err)
+			require.Len(t, listResults.Items, 1)
+			require.Equal(t, uidAtoB, listResults.Items[0].GetName())
+
+			// Get the value
+			getResults, err := correlationsClient.Resource.Get(ctx, uidAtoB, v1.GetOptions{})
+			require.NoError(t, err)
+			require.Equal(t, uidAtoB, getResults.GetName())
+		})
+	}
+}

pkg/tests/apis/helper.go

@@ -784,8 +784,12 @@ func (c *K8sTestHelper) GetGroupVersionInfoJSON(group string) string {
 func (c *K8sTestHelper) CreateDS(cmd *datasources.AddDataSourceCommand) *datasources.DataSource {
 	c.t.Helper()
 
+	require.NotZero(c.t, cmd.OrgID, "requires a non zero orgId")
 	dataSource, err := c.env.Server.HTTPServer.DataSourcesService.AddDataSource(context.Background(), cmd)
 	require.NoError(c.t, err)
+	if cmd.UID != "" {
+		require.Equal(c.t, cmd.UID, dataSource.UID)
+	}
 	return dataSource
 }