From bfa1f03315c943603b2985d831207368308edbe8 Mon Sep 17 00:00:00 2001
From: Luis Rodrigues <103431660+devluisrodrigues@users.noreply.github.com>
Date: Tue, 5 Nov 2024 12:29:52 -0300
Subject: [PATCH] Prometheus: Fix query editor crash in response to invalid
 query (#94421)

* Quick fix for RenderParams Function

* Removing unnecessary optional chaining

Co-authored-by: Nick Richmond <5732000+NWRichmond@users.noreply.github.com>

* Removing unittests for RenderParams

---------

Co-authored-by: Nick Richmond <5732000+NWRichmond@users.noreply.github.com>
---
 .../grafana-prometheus/src/querybuilder/operationUtils.ts     | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/packages/grafana-prometheus/src/querybuilder/operationUtils.ts b/packages/grafana-prometheus/src/querybuilder/operationUtils.ts
index a0bda0d598f..bf5bc98c0ad 100644
--- a/packages/grafana-prometheus/src/querybuilder/operationUtils.ts
+++ b/packages/grafana-prometheus/src/querybuilder/operationUtils.ts
@@ -96,8 +96,8 @@ export function rangeRendererLeftWithParams(
 function renderParams(model: QueryBuilderOperation, def: QueryBuilderOperationDef, innerExpr: string) {
   return (model.params ?? []).map((value, index) => {
     const paramDef = def.params[index];
-    if (paramDef.type === 'string') {
-      return '"' + value + '"';
+    if (paramDef?.type === 'string') {
+      return `"${value}"`;
     }
 
     return value;