From c024d51a3830fc7be110b5216acef95f80f76208 Mon Sep 17 00:00:00 2001 From: Josh Hunt Date: Thu, 11 Apr 2024 09:40:30 +0100 Subject: [PATCH] Chore: Remove a buncha stuff from Sandbox TestStuffPage (#85876) --- .betterer.results | 3 - public/app/features/sandbox/TestStuffPage.tsx | 155 +++--------------- 2 files changed, 22 insertions(+), 136 deletions(-) diff --git a/.betterer.results b/.betterer.results index 866eb02a62b..1de60f13bac 100644 --- a/.betterer.results +++ b/.betterer.results @@ -4057,9 +4057,6 @@ exports[`better eslint`] = { "public/app/features/sandbox/BenchmarksPage.tsx:5381": [ [0, 0, 0, "\'VerticalGroup\' import from \'@grafana/ui\' is restricted from being used by a pattern. Use Stack component instead.", "0"] ], - "public/app/features/sandbox/TestStuffPage.tsx:5381": [ - [0, 0, 0, "\'HorizontalGroup\' import from \'@grafana/ui\' is restricted from being used by a pattern. Use Stack component instead.", "0"] - ], "public/app/features/search/page/components/ActionRow.tsx:5381": [ [0, 0, 0, "\'HorizontalGroup\' import from \'@grafana/ui\' is restricted from being used by a pattern. Use Stack component instead.", "0"], [0, 0, 0, "Styles should be written using objects.", "1"], diff --git a/public/app/features/sandbox/TestStuffPage.tsx b/public/app/features/sandbox/TestStuffPage.tsx index c1e20ed8c87..e5507117cb5 100644 --- a/public/app/features/sandbox/TestStuffPage.tsx +++ b/public/app/features/sandbox/TestStuffPage.tsx @@ -1,59 +1,12 @@ -import React, { useMemo, useState } from 'react'; -import { useObservable } from 'react-use'; -import AutoSizer from 'react-virtualized-auto-sizer'; +import React from 'react'; -import { - ApplyFieldOverrideOptions, - DataConfigSource, - dateMath, - FieldColorModeId, - NavModelItem, - PanelData, -} from '@grafana/data'; +import { NavModelItem } from '@grafana/data'; import { getPluginExtensions, isPluginExtensionLink } from '@grafana/runtime'; -import { Button, HorizontalGroup, LinkButton, Table } from '@grafana/ui'; +import { Button, LinkButton, Stack } from '@grafana/ui'; import { Page } from 'app/core/components/Page/Page'; -import { config } from 'app/core/config'; import { useAppNotification } from 'app/core/copy/appNotification'; -import { QueryGroupOptions } from 'app/types'; - -import { PanelRenderer } from '../panel/components/PanelRenderer'; -import { QueryGroup } from '../query/components/QueryGroup'; -import { PanelQueryRunner } from '../query/state/PanelQueryRunner'; - -interface State { - queryRunner: PanelQueryRunner; - queryOptions: QueryGroupOptions; - data?: PanelData; -} export const TestStuffPage = () => { - const [state, setState] = useState(getDefaultState()); - const { queryOptions, queryRunner } = state; - - const onRunQueries = () => { - const timeRange = { from: 'now-1h', to: 'now' }; - - queryRunner.run({ - queries: queryOptions.queries, - datasource: queryOptions.dataSource, - timezone: 'browser', - timeRange: { from: dateMath.parse(timeRange.from)!, to: dateMath.parse(timeRange.to)!, raw: timeRange }, - maxDataPoints: queryOptions.maxDataPoints ?? 100, - minInterval: queryOptions.minInterval, - }); - }; - - const onOptionsChange = (queryOptions: QueryGroupOptions) => { - setState({ ...state, queryOptions }); - }; - - /** - * Subscribe to data - */ - const observable = useMemo(() => queryRunner.getData({ withFieldConfig: true, withTransforms: true }), [queryRunner]); - const data = useObservable(observable); - const node: NavModelItem = { id: 'test-page', text: 'Test page', @@ -66,93 +19,29 @@ export const TestStuffPage = () => { return ( - - - - - {data && ( - - {({ width }) => { - return ( -
- - - - ); - }} - - )} -
- -
-
- - - -
- + + + + + + + ); }; -export function getDefaultState(): State { - const options: ApplyFieldOverrideOptions = { - fieldConfig: { - defaults: { - color: { - mode: FieldColorModeId.PaletteClassic, - }, - }, - overrides: [], - }, - replaceVariables: (v: string) => v, - theme: config.theme2, - }; - - const dataConfig: DataConfigSource = { - getTransformations: () => [], - getFieldOverrideOptions: () => options, - getDataSupport: () => ({ annotations: false, alertStates: false }), - }; - - return { - queryRunner: new PanelQueryRunner(dataConfig), - queryOptions: { - queries: [], - dataSource: { - name: 'gdev-testdata', - }, - maxDataPoints: 100, - }, - }; -} - function LinkToBasicApp({ extensionPointId }: { extensionPointId: string }) { const { extensions } = getPluginExtensions({ extensionPointId });