From c02578336765ebbf14822e7101cb86473e424c86 Mon Sep 17 00:00:00 2001 From: Alexa V <239999+axelavargas@users.noreply.github.com> Date: Thu, 11 May 2023 10:59:50 +0200 Subject: [PATCH] Dashboard: Fix Drawer validation to avoid errors with empty `request` objects (#68214) --- .../dashboard/components/Inspector/InspectContent.tsx | 4 +++- public/app/features/inspector/InspectStatsTab.tsx | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/public/app/features/dashboard/components/Inspector/InspectContent.tsx b/public/app/features/dashboard/components/Inspector/InspectContent.tsx index 5b2bbf9956d..96a81bb7838 100644 --- a/public/app/features/dashboard/components/Inspector/InspectContent.tsx +++ b/public/app/features/dashboard/components/Inspector/InspectContent.tsx @@ -1,3 +1,4 @@ +import { isEmpty } from 'lodash'; import React, { useState } from 'react'; import { CoreApp, DataSourceApi, formattedValueToString, getValueFormat, PanelData, PanelPlugin } from '@grafana/data'; @@ -114,7 +115,8 @@ export const InspectContent = ({ function formatStats(data: PanelData) { const { request } = data; - if (!request) { + + if (!request || isEmpty(request)) { return ''; } diff --git a/public/app/features/inspector/InspectStatsTab.tsx b/public/app/features/inspector/InspectStatsTab.tsx index 16886e34262..c46bc2c8dbf 100644 --- a/public/app/features/inspector/InspectStatsTab.tsx +++ b/public/app/features/inspector/InspectStatsTab.tsx @@ -44,7 +44,7 @@ export const InspectStatsTab = ({ data, timeZone }: InspectStatsTabProps) => { } stats.push({ displayName: t('dashboard.inspect-stats.queries', 'Number of queries'), - value: data.request.targets.length, + value: data.request.targets?.length ?? 0, }); stats.push({ displayName: t('dashboard.inspect-stats.rows', 'Total number rows'),