Dashboards: Fix missing Ctrl+O keyboard shortcut for crosshair toggle (#111310)
* Dashboard Scenes: Fix missing Ctrl+O keyboard shortcut for crosshair toggle - Add missing mod+o keybind to dashboard scenes keyboard shortcuts - Implement crosshair state cycling (Default -> Crosshair -> Tooltip -> Default) - Add comprehensive unit tests for keyboard shortcuts functionality - Add e2e test to verify shortcut works and prevents browser file dialog - Fix ensures parity between legacy and scenes dashboard implementations Fixes issue where Ctrl+O/Cmd+O was opening browser file dialog instead of toggling shared crosshair modes in scenes-based dashboards. * Remove waitForTimeout from e2e test - Replace arbitrary timeouts with proper element waiting - Use waitFor with visible state instead of setTimeout - Improve test reliability and follow Playwright best practices * Optimize e2e test for crosshair keyboard shortcut - Remove unnecessary console logging and timeout settings - Simplify assertions to only check the currently selected radio button - Improve test performance by reducing DOM queries - Focus on essential functionality verification * Fix linting
This commit is contained in:
@@ -1055,6 +1055,7 @@ github.com/grafana/dskit v0.0.0-20250818234656-8ff9c6532e85/go.mod h1:kImsvJ1xnm
|
||||
github.com/grafana/go-gelf/v2 v2.0.1 h1:BOChP0h/jLeD+7F9mL7tq10xVkDG15he3T1zHuQaWak=
|
||||
github.com/grafana/go-gelf/v2 v2.0.1/go.mod h1:lexHie0xzYGwCgiRGcvZ723bSNyNI8ZRD4s0CLobh90=
|
||||
github.com/grafana/gomemcache v0.0.0-20250228145437-da7b95fd2ac1/go.mod h1:j/s0jkda4UXTemDs7Pgw/vMT06alWc42CHisvYac0qw=
|
||||
github.com/grafana/gomemcache v0.0.0-20250828162811-a96f6acee2fe/go.mod h1:j/s0jkda4UXTemDs7Pgw/vMT06alWc42CHisvYac0qw=
|
||||
github.com/grafana/grafana-app-sdk v0.40.1/go.mod h1:4P8h7VB6KcDjX9bAoBQc6IP8iNylxe6bSXLR9gA39gM=
|
||||
github.com/grafana/grafana-app-sdk v0.41.0 h1:SYHN3U7B1myRKY3UZZDkFsue9TDmAOap0UrQVTqtYBU=
|
||||
github.com/grafana/grafana-app-sdk v0.41.0/go.mod h1:Wg/3vEZfok1hhIWiHaaJm+FwkosfO98o8KbeLFEnZpY=
|
||||
|
||||
Reference in New Issue
Block a user