Chore: Disable default golangci-lint filter (#29751)

* Disable default golangci-lint filter

Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>

* Chore: Fix linter warnings

Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>

pkg/services/contexthandler/auth_proxy_test.go

@@ -65,7 +65,9 @@ func TestInitContextWithAuthProxy_CachedInvalidUserID(t *testing.T) {
 		Logger: log.New("Test"),
 	}
 	req.Header.Set(svc.Cfg.AuthProxyHeaderName, name)
-	key := fmt.Sprintf(authproxy.CachePrefix, authproxy.HashCacheKey(name))
+	h, err := authproxy.HashCacheKey(name)
+	require.NoError(t, err)
+	key := fmt.Sprintf(authproxy.CachePrefix, h)
 
 	t.Logf("Injecting stale user ID in cache with key %q", key)
 	err = svc.RemoteCache.Set(key, int64(33), 0)

pkg/services/contexthandler/authproxy/authproxy.go

@@ -141,25 +141,29 @@ func (auth *AuthProxy) IsAllowedIP() error {
 	))
 }
 
-func HashCacheKey(key string) string {
+func HashCacheKey(key string) (string, error) {
 	hasher := fnv.New128a()
-	// according to the documentation, Hash.Write cannot error, but linter is complaining
-	hasher.Write([]byte(key)) // nolint: errcheck
-	return hex.EncodeToString(hasher.Sum(nil))
+	if _, err := hasher.Write([]byte(key)); err != nil {
+		return "", err
+	}
+	return hex.EncodeToString(hasher.Sum(nil)), nil
 }
 
 // getKey forms a key for the cache based on the headers received as part of the authentication flow.
 // Our configuration supports multiple headers. The main header contains the email or username.
 // And the additional ones that allow us to specify extra attributes: Name, Email or Groups.
-func (auth *AuthProxy) getKey() string {
+func (auth *AuthProxy) getKey() (string, error) {
 	key := strings.TrimSpace(auth.header) // start the key with the main header
 
 	auth.headersIterator(func(_, header string) {
 		key = strings.Join([]string{key, header}, "-") // compose the key with any additional headers
 	})
 
-	hashedKey := HashCacheKey(key)
-	return fmt.Sprintf(CachePrefix, hashedKey)
+	hashedKey, err := HashCacheKey(key)
+	if err != nil {
+		return "", err
+	}
+	return fmt.Sprintf(CachePrefix, hashedKey), nil
 }
 
 // Login logs in user ID by whatever means possible.
@@ -194,7 +198,10 @@ func (auth *AuthProxy) Login(logger log.Logger, ignoreCache bool) (int64, error)
 
 // GetUserViaCache gets user ID from cache.
 func (auth *AuthProxy) GetUserViaCache(logger log.Logger) (int64, error) {
-	cacheKey := auth.getKey()
+	cacheKey, err := auth.getKey()
+	if err != nil {
+		return 0, err
+	}
 	logger.Debug("Getting user ID via auth cache", "cacheKey", cacheKey)
 	userID, err := auth.remoteCache.Get(cacheKey)
 	if err != nil {
@@ -208,7 +215,10 @@ func (auth *AuthProxy) GetUserViaCache(logger log.Logger) (int64, error) {
 
 // RemoveUserFromCache removes user from cache.
 func (auth *AuthProxy) RemoveUserFromCache(logger log.Logger) error {
-	cacheKey := auth.getKey()
+	cacheKey, err := auth.getKey()
+	if err != nil {
+		return err
+	}
 	logger.Debug("Removing user from auth cache", "cacheKey", cacheKey)
 	if err := auth.remoteCache.Delete(cacheKey); err != nil {
 		return err
@@ -318,18 +328,20 @@ func (auth *AuthProxy) GetSignedInUser(userID int64) (*models.SignedInUser, erro
 
 // Remember user in cache
 func (auth *AuthProxy) Remember(id int64) error {
-	key := auth.getKey()
+	key, err := auth.getKey()
+	if err != nil {
+		return err
+	}
 
 	// Check if user already in cache
-	userID, _ := auth.remoteCache.Get(key)
-	if userID != nil {
+	userID, err := auth.remoteCache.Get(key)
+	if err == nil && userID != nil {
 		return nil
 	}
 
 	expiration := time.Duration(auth.cfg.AuthProxySyncTTL) * time.Minute
 
-	err := auth.remoteCache.Set(key, id, expiration)
-	if err != nil {
+	if err := auth.remoteCache.Set(key, id, expiration); err != nil {
 		return err
 	}
 

pkg/services/contexthandler/authproxy/authproxy_test.go

@@ -87,12 +87,16 @@ func TestMiddlewareContext(t *testing.T) {
 	t.Run("When the cache only contains the main header with a simple cache key", func(t *testing.T) {
 		const id int64 = 33
 		// Set cache key
-		key := fmt.Sprintf(CachePrefix, HashCacheKey(hdrName))
-		err := cache.Set(key, id, 0)
+		h, err := HashCacheKey(hdrName)
+		require.NoError(t, err)
+		key := fmt.Sprintf(CachePrefix, h)
+		err = cache.Set(key, id, 0)
 		require.NoError(t, err)
 		// Set up the middleware
 		auth := prepareMiddleware(t, cache, nil)
-		assert.Equal(t, key, auth.getKey())
+		gotKey, err := auth.getKey()
+		require.NoError(t, err)
+		assert.Equal(t, key, gotKey)
 
 		gotID, err := auth.Login(logger, false)
 		require.NoError(t, err)
@@ -104,15 +108,17 @@ func TestMiddlewareContext(t *testing.T) {
 		const id int64 = 33
 		const group = "grafana-core-team"
 
-		key := fmt.Sprintf(CachePrefix, HashCacheKey(hdrName+"-"+group))
-		err := cache.Set(key, id, 0)
+		h, err := HashCacheKey(hdrName + "-" + group)
+		require.NoError(t, err)
+		key := fmt.Sprintf(CachePrefix, h)
+		err = cache.Set(key, id, 0)
 		require.NoError(t, err)
 
 		auth := prepareMiddleware(t, cache, func(req *http.Request, cfg *setting.Cfg) {
 			req.Header.Set("X-WEBAUTH-GROUPS", group)
 			cfg.AuthProxyHeaders = map[string]string{"Groups": "X-WEBAUTH-GROUPS"}
 		})
-		assert.Equal(t, "auth-proxy-sync-ttl:14f69b7023baa0ac98c96b31cec07bc0", auth.getKey())
+		assert.Equal(t, "auth-proxy-sync-ttl:14f69b7023baa0ac98c96b31cec07bc0", key)
 
 		gotID, err := auth.Login(logger, false)
 		require.NoError(t, err)

pkg/services/contexthandler/contexthandler_test.go

@@ -64,8 +64,12 @@ func TestTokenRotationAtEndOfRequest(t *testing.T) {
 	ctxHdlr.rotateEndOfRequestFunc(reqContext, uts, token)(reqContext.Resp)
 
 	foundLoginCookie := false
+	// nolint:bodyclose
 	resp := rr.Result()
-	defer resp.Body.Close()
+	t.Cleanup(func() {
+		err := resp.Body.Close()
+		assert.NoError(t, err)
+	})
 	for _, c := range resp.Cookies() {
 		if c.Name == "login_token" {
 			foundLoginCookie = true