From c3f1d1a647456c0a7c8ce97d9c9dd26f4eff1290 Mon Sep 17 00:00:00 2001 From: bergquist Date: Fri, 13 May 2016 13:26:57 +0200 Subject: [PATCH] fix(influxdb): fixes extra semi colon due to hidden series closes #5005 --- CHANGELOG.md | 1 + public/app/plugins/datasource/influxdb/datasource.ts | 10 +++++++--- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index d4aae6bdf29..bd0b91ec52c 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -3,6 +3,7 @@ * **Templating**: Fixed issue mixing row repeat and panel repeats, fixes [#4988](https://github.com/grafana/grafana/issues/4988) * **Templating**: Fixed issue detecting dependencies in nested variables, fixes [#4987](https://github.com/grafana/grafana/issues/4987), fixes [#4986](https://github.com/grafana/grafana/issues/4986) * **Graph**: Fixed broken PNG rendering in graph panel, fixes [#5025](https://github.com/grafana/grafana/issues/5025) +* **Influxdb**: Fixes crash when hiding middle serie, fixes [#5005](https://github.com/grafana/grafana/issues/5005) # 3.0.1 Stable (2016-05-11) diff --git a/public/app/plugins/datasource/influxdb/datasource.ts b/public/app/plugins/datasource/influxdb/datasource.ts index 4037e963bcb..40c7ba16f53 100644 --- a/public/app/plugins/datasource/influxdb/datasource.ts +++ b/public/app/plugins/datasource/influxdb/datasource.ts @@ -45,7 +45,7 @@ export default class InfluxDatasource { var i, y; var allQueries = _.map(options.targets, (target) => { - if (target.hide) { return []; } + if (target.hide) { return ""; } queryTargets.push(target); @@ -54,8 +54,12 @@ export default class InfluxDatasource { var query = queryModel.render(true); query = query.replace(/\$interval/g, (target.interval || options.interval)); return query; - - }).join(";"); + }).reduce((acc, current) => { + if (current !== "") { + acc += ";" + current; + } + return acc; + }); // replace grafana variables allQueries = allQueries.replace(/\$timeFilter/g, timeFilter);