Dashboards: Add Dashboard Schema validation (2) (#103844)

* Activate schema validation and align underlying systems

* update to save as v0 if not the right schema version

* Resolve merge conflicts

* Move RequireApiErrorStatus to tests package

* Add mutation tests

* Fix lint

* Only do min version check if dashboard is v1

* Fix lint and disable provisioning test

* Revert provisioning changes

* Revert more tests and add schema test

* Reran gen

* SQL Dashboard save

* Adjust APIVERSION

* Fixed mutation test

* Add logging on downgrade

---------

Co-authored-by: Marco de Abreu <18629099+marcoabreu@users.noreply.github.com>
Co-authored-by: Stephanie Hingtgen <stephanie.hingtgen@grafana.com>

pkg/registry/apis/dashboard/mutation_test.go

@@ -6,10 +6,13 @@ import (
 
 	dashv0 "github.com/grafana/grafana/apps/dashboard/pkg/apis/dashboard/v0alpha1"
 	dashv1 "github.com/grafana/grafana/apps/dashboard/pkg/apis/dashboard/v1alpha1"
+	"github.com/grafana/grafana/apps/dashboard/pkg/apis/dashboard/v2alpha1"
 	"github.com/grafana/grafana/apps/dashboard/pkg/migration/schemaversion"
 	common "github.com/grafana/grafana/pkg/apimachinery/apis/common/v0alpha1"
 	"github.com/grafana/grafana/pkg/apimachinery/utils"
+	"github.com/grafana/grafana/pkg/services/featuremgmt"
 	"github.com/stretchr/testify/require"
+	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/apimachinery/pkg/runtime"
 	"k8s.io/apimachinery/pkg/runtime/schema"
 	"k8s.io/apiserver/pkg/admission"
@@ -17,12 +20,14 @@ import (
 
 func TestDashboardAPIBuilder_Mutate(t *testing.T) {
 	tests := []struct {
-		name              string
-		inputObj          runtime.Object
-		operation         admission.Operation
-		expectedID        int64
-		migrationExpected bool
-		expectedError     bool
+		name                string
+		inputObj            runtime.Object
+		operation           admission.Operation
+		expectedID          int64
+		migrationExpected   bool
+		expectedTitle       string
+		expectedError       bool
+		fieldValidationMode string
 	}{
 		{
 			name: "should skip non-create/update operations",
@@ -48,6 +53,47 @@ func TestDashboardAPIBuilder_Mutate(t *testing.T) {
 			operation:  admission.Create,
 			expectedID: 123,
 		},
+		{
+			name: "v0 should not fail with invalid schema",
+			inputObj: &dashv0.Dashboard{
+				Spec: common.Unstructured{
+					Object: map[string]interface{}{
+						"id":       float64(123),
+						"revision": "revision-is-a-number",
+					},
+				},
+			},
+			operation:  admission.Create,
+			expectedID: 123,
+		},
+		{
+			name: "v1 should fail with invalid schema",
+			inputObj: &dashv1.Dashboard{
+				Spec: common.Unstructured{
+					Object: map[string]interface{}{
+						"id":       float64(123),
+						"revision": "revision-is-a-number",
+					},
+				},
+			},
+			operation:     admission.Create,
+			expectedError: true,
+		},
+		{
+			name: "v1 should not fail with invalid schema and FieldValidationIgnore is set",
+			inputObj: &dashv1.Dashboard{
+				Spec: common.Unstructured{
+					Object: map[string]interface{}{
+						"id":       float64(123),
+						"revision": "revision-is-a-number",
+					},
+				},
+			},
+			operation:           admission.Create,
+			fieldValidationMode: metav1.FieldValidationIgnore,
+			expectedError:       false,
+			expectedID:          123,
+		},
 		{
 			name: "v1 should migrate dashboard to the latest version, if possible, and set as label",
 			inputObj: &dashv1.Dashboard{
@@ -75,11 +121,47 @@ func TestDashboardAPIBuilder_Mutate(t *testing.T) {
 			operation:     admission.Create,
 			expectedError: true,
 		},
+		{
+			name: "v1 should not error mutation hook if migration fails and FieldValidationIgnore is set",
+			inputObj: &dashv1.Dashboard{
+				Spec: common.Unstructured{
+					Object: map[string]interface{}{
+						"id":            float64(456),
+						"schemaVersion": schemaversion.MIN_VERSION - 1,
+					},
+				},
+			},
+			expectedID:          456,
+			operation:           admission.Create,
+			fieldValidationMode: metav1.FieldValidationIgnore,
+			expectedError:       false,
+		},
+		{
+			name: "v2 should set layout if it is not set",
+			inputObj: &v2alpha1.Dashboard{
+				Spec: v2alpha1.DashboardSpec{
+					Title: "test123",
+				},
+			},
+			operation:     admission.Create,
+			expectedTitle: "test123",
+		},
 	}
 
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
-			b := &DashboardsAPIBuilder{}
+			b := &DashboardsAPIBuilder{
+				features: featuremgmt.WithFeatures(),
+			}
+			var operationOptions runtime.Object
+			switch tt.operation {
+			case admission.Create:
+				operationOptions = &metav1.CreateOptions{FieldValidation: tt.fieldValidationMode}
+			case admission.Update:
+				operationOptions = &metav1.UpdateOptions{FieldValidation: tt.fieldValidationMode}
+			default:
+				operationOptions = nil
+			}
 			err := b.Mutate(context.Background(), admission.NewAttributesRecord(
 				tt.inputObj,
 				nil,
@@ -89,7 +171,7 @@ func TestDashboardAPIBuilder_Mutate(t *testing.T) {
 				schema.GroupVersionResource{},
 				"",
 				tt.operation,
-				nil,
+				operationOptions,
 				false,
 				nil,
 			), nil)
@@ -117,6 +199,10 @@ func TestDashboardAPIBuilder_Mutate(t *testing.T) {
 					if tt.migrationExpected {
 						require.Equal(t, schemaversion.LATEST_VERSION, schemaVersion, "dashboard should be migrated to the latest version")
 					}
+				case *v2alpha1.Dashboard:
+					require.Equal(t, tt.expectedTitle, v.Spec.Title, "title should be set")
+					require.NotNil(t, v.Spec.Layout, "layout should be set")
+					require.NotNil(t, v.Spec.Layout.GridLayoutKind, "layout should be a GridLayout")
 				}
 			}
 		})