Plugins: Do not fail bootstrap stage if single decorate step fails (#73147)

* don't fail all if decorate step fails

* fix casing

* include err too

* cover pluginsintegration too

pkg/plugins/manager/pipeline/discovery/discovery.go

@@ -58,17 +58,17 @@ func New(cfg *config.Cfg, opts Opts) *Discovery {
 
 // Discover will execute the Find and Filter steps of the Discovery stage.
 func (d *Discovery) Discover(ctx context.Context, src plugins.PluginSource) ([]*plugins.FoundBundle, error) {
-	found, err := d.findStep(ctx, src)
+	discoveredPlugins, err := d.findStep(ctx, src)
 	if err != nil {
 		return nil, err
 	}
 
-	for _, filterStep := range d.findFilterSteps {
-		found, err = filterStep(ctx, src.PluginClass(ctx), found)
+	for _, filter := range d.findFilterSteps {
+		discoveredPlugins, err = filter(ctx, src.PluginClass(ctx), discoveredPlugins)
 		if err != nil {
 			return nil, err
 		}
 	}
 
-	return found, nil
+	return discoveredPlugins, nil
 }

pkg/plugins/manager/pipeline/discovery/steps.go

@@ -37,14 +37,14 @@ func (d *DuplicatePluginValidation) Filter(ctx context.Context, bundles []*plugi
 	for _, b := range bundles {
 		_, exists := d.registry.Plugin(ctx, b.Primary.JSONData.ID)
 		if exists {
-			d.log.Warn("Skipping loading of plugin as it's a duplicate", "pluginID", b.Primary.JSONData.ID)
+			d.log.Warn("Skipping loading of plugin as it's a duplicate", "pluginId", b.Primary.JSONData.ID)
 			continue
 		}
 
 		for _, child := range b.Children {
 			_, exists = d.registry.Plugin(ctx, child.JSONData.ID)
 			if exists {
-				d.log.Warn("Skipping loading of child plugin as it's a duplicate", "pluginID", child.JSONData.ID)
+				d.log.Warn("Skipping loading of child plugin as it's a duplicate", "pluginId", child.JSONData.ID)
 				continue
 			}
 		}