From c75137b2d3706adadb382cd5e4c58891601bf2e3 Mon Sep 17 00:00:00 2001
From: Sergej-Vlasov <37613182+Sergej-Vlasov@users.noreply.github.com>
Date: Fri, 28 Nov 2025 13:18:14 +0000
Subject: [PATCH] QueryVariableForm: Refil query variable query on default data
 source update (#114491)

* refil qury variable query on default ds update

* refactor datasource update logic

* adjust test
---
 .../components/QueryVariableForm.test.tsx        |  2 +-
 .../variables/components/QueryVariableForm.tsx   | 16 +++++++++++-----
 .../editors/QueryVariableEditor.test.tsx         | 10 ++++++----
 .../variables/editors/QueryVariableEditor.tsx    |  4 ++--
 4 files changed, 20 insertions(+), 12 deletions(-)

diff --git a/public/app/features/dashboard-scene/settings/variables/components/QueryVariableForm.test.tsx b/public/app/features/dashboard-scene/settings/variables/components/QueryVariableForm.test.tsx
index 63a1912fde7..d3d23396974 100644
--- a/public/app/features/dashboard-scene/settings/variables/components/QueryVariableForm.test.tsx
+++ b/public/app/features/dashboard-scene/settings/variables/components/QueryVariableForm.test.tsx
@@ -178,7 +178,7 @@ describe('QueryVariableEditorForm', () => {
     await userEvent.click(screen.getByText(/prometheus/i));
 
     expect(mockOnDataSourceChange).toHaveBeenCalledTimes(1);
-    expect(mockOnDataSourceChange).toHaveBeenCalledWith(promDatasource, undefined);
+    expect(mockOnDataSourceChange).toHaveBeenCalledWith(promDatasource);
   });
 
   it('should call onQueryChange when changing the query', async () => {
diff --git a/public/app/features/dashboard-scene/settings/variables/components/QueryVariableForm.tsx b/public/app/features/dashboard-scene/settings/variables/components/QueryVariableForm.tsx
index 3849fb0a2c5..030de016a5f 100644
--- a/public/app/features/dashboard-scene/settings/variables/components/QueryVariableForm.tsx
+++ b/public/app/features/dashboard-scene/settings/variables/components/QueryVariableForm.tsx
@@ -1,4 +1,4 @@
-import { FormEvent } from 'react';
+import { FormEvent, useCallback } from 'react';
 import { useAsync } from 'react-use';
 
 import { DataSourceInstanceSettings, SelectableValue, TimeRange } from '@grafana/data';
@@ -27,7 +27,7 @@ type VariableQueryType = QueryVariable['state']['query'];
 
 interface QueryVariableEditorFormProps {
   datasource?: DataSourceRef;
-  onDataSourceChange: (dsSettings: DataSourceInstanceSettings) => void;
+  onDataSourceChange: (dsSettings: DataSourceInstanceSettings, preserveQuery?: boolean) => void;
   query: VariableQueryType;
   onQueryChange: (query: VariableQueryType) => void;
   onLegacyQueryChange: (query: VariableQueryType, definition: string) => void;
@@ -89,17 +89,23 @@ export function QueryVariableEditorForm({
       onQueryChange(query);
     }
 
+    // update data source if it is not defined in variable model
     if (!datasourceRef) {
       const instanceSettings = getDataSourceSrv().getInstanceSettings({ type: datasource.type, uid: datasource.uid });
-
       if (instanceSettings) {
-        onDataSourceChange(instanceSettings);
+        onDataSourceChange(instanceSettings, true);
       }
     }
 
     return { datasource, VariableQueryEditor };
   }, [datasourceRef]);
 
+  // adjusting type miss match between DataSourcePicker onChange and onDataSourceChange
+  const datasourceChangeHandler = useCallback(
+    (dsSettings: DataSourceInstanceSettings) => onDataSourceChange(dsSettings),
+    [onDataSourceChange]
+  );
+
   const { datasource, VariableQueryEditor } = dsConfig ?? {};
 
   return (
@@ -111,7 +117,7 @@ export function QueryVariableEditorForm({
         label={t('dashboard-scene.query-variable-editor-form.label-data-source', 'Data source')}
         htmlFor="data-source-picker"
       >
-        <DataSourcePicker current={datasourceRef} onChange={onDataSourceChange} variables={true} width={30} />
+        <DataSourcePicker current={datasourceRef} onChange={datasourceChangeHandler} variables={true} width={30} />
       </Field>
 
       {datasource && VariableQueryEditor && (
diff --git a/public/app/features/dashboard-scene/settings/variables/editors/QueryVariableEditor.test.tsx b/public/app/features/dashboard-scene/settings/variables/editors/QueryVariableEditor.test.tsx
index 26f9516e40a..99385438e87 100644
--- a/public/app/features/dashboard-scene/settings/variables/editors/QueryVariableEditor.test.tsx
+++ b/public/app/features/dashboard-scene/settings/variables/editors/QueryVariableEditor.test.tsx
@@ -152,10 +152,12 @@ describe('QueryVariableEditor', () => {
     const onRunQueryMock = jest.fn();
     const variable = new QueryVariable({ datasource: undefined, query: '' });
 
-    await setup({
-      variable,
-      onRunQuery: onRunQueryMock,
-    });
+    await act(() =>
+      setup({
+        variable,
+        onRunQuery: onRunQueryMock,
+      })
+    );
 
     await waitFor(async () => {
       expect(variable.state.datasource).not.toBe(undefined);
diff --git a/public/app/features/dashboard-scene/settings/variables/editors/QueryVariableEditor.tsx b/public/app/features/dashboard-scene/settings/variables/editors/QueryVariableEditor.tsx
index da1649776b2..106468b2b31 100644
--- a/public/app/features/dashboard-scene/settings/variables/editors/QueryVariableEditor.tsx
+++ b/public/app/features/dashboard-scene/settings/variables/editors/QueryVariableEditor.tsx
@@ -68,10 +68,10 @@ export function QueryVariableEditor({ variable, onRunQuery }: QueryVariableEdito
   const onAllowCustomValueChange = (event: FormEvent<HTMLInputElement>) => {
     variable.setState({ allowCustomValue: event.currentTarget.checked });
   };
-  const onDataSourceChange = (dsInstanceSettings: DataSourceInstanceSettings) => {
+  const onDataSourceChange = (dsInstanceSettings: DataSourceInstanceSettings, preserveQuery = false) => {
     const datasource = getDataSourceRef(dsInstanceSettings);
 
-    if ((variable.state.datasource?.type || '') !== datasource.type) {
+    if (!preserveQuery && (variable.state.datasource?.type || '') !== datasource.type) {
       variable.setState({ datasource, query: '', definition: '' });
       return;
     }