From c75bc5a6cf9a308fc0e0971c1f9f364203dda8a3 Mon Sep 17 00:00:00 2001 From: Tobias Skarhed <1438972+tskarhed@users.noreply.github.com> Date: Tue, 2 Apr 2024 11:41:46 +0200 Subject: [PATCH] Keybindings: Replace mod+h as help shortcut with ? (#85449) HelpModal: Remove cmd+h as help shortcut --- docs/sources/dashboards/use-dashboards/index.md | 2 +- public/app/core/components/help/HelpModal.tsx | 2 +- public/app/core/services/keybindingSrv.ts | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/sources/dashboards/use-dashboards/index.md b/docs/sources/dashboards/use-dashboards/index.md index cb20fd7e62b..6ea8331e142 100644 --- a/docs/sources/dashboards/use-dashboards/index.md +++ b/docs/sources/dashboards/use-dashboards/index.md @@ -62,7 +62,7 @@ The following image and descriptions highlight all dashboard features. ## Keyboard shortcuts -Grafana has a number of keyboard shortcuts available. Press `?` or `Ctrl+h` on your keyboard to display all keyboard shortcuts available in your version of Grafana. +Grafana has a number of keyboard shortcuts available. Press `?` on your keyboard to display all keyboard shortcuts available in your version of Grafana. - `Ctrl+S`: Saves the current dashboard. - `f`: Opens the dashboard finder / search. diff --git a/public/app/core/components/help/HelpModal.tsx b/public/app/core/components/help/HelpModal.tsx index 3d3b3f5f904..e09721a0590 100644 --- a/public/app/core/components/help/HelpModal.tsx +++ b/public/app/core/components/help/HelpModal.tsx @@ -27,7 +27,7 @@ const getShortcuts = (modKey: string) => { description: t('help-modal.shortcuts-description.exit-edit/setting-views', 'Exit edit/setting views'), }, { - keys: [`${modKey} + h`], + keys: ['?'], description: t('help-modal.shortcuts-description.show-all-shortcuts', 'Show all keyboard shortcuts'), }, { keys: ['c', 't'], description: t('help-modal.shortcuts-description.change-theme', 'Change theme') }, diff --git a/public/app/core/services/keybindingSrv.ts b/public/app/core/services/keybindingSrv.ts index 2d48dee13c6..f2f0419ada0 100644 --- a/public/app/core/services/keybindingSrv.ts +++ b/public/app/core/services/keybindingSrv.ts @@ -40,7 +40,7 @@ export class KeybindingSrv { // Chromeless pages like login and signup page don't get any global bindings if (!route.chromeless) { - this.bind(['?', 'mod+h'], this.showHelpModal); + this.bind('?', this.showHelpModal); this.bind('g h', this.goToHome); this.bind('g d', this.goToDashboards); this.bind('g e', this.goToExplore);