From c7ae8f42c209cd281baed5ea6523d145e1aa3b87 Mon Sep 17 00:00:00 2001 From: Matheus Macabu Date: Thu, 12 Jun 2025 15:37:54 +0200 Subject: [PATCH] Secrets: Always clear the status.externalId when receiving requests (#106606) --- pkg/registry/apis/secret/register.go | 1 + .../apis/secret/reststorage/secure_value_rest_test.go | 6 ++++-- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/pkg/registry/apis/secret/register.go b/pkg/registry/apis/secret/register.go index e5dadc5b4e6..32b191b63b1 100644 --- a/pkg/registry/apis/secret/register.go +++ b/pkg/registry/apis/secret/register.go @@ -691,6 +691,7 @@ func (b *SecretAPIBuilder) Mutate(ctx context.Context, a admission.Attributes, o if ok && sv != nil { sv.Status.Phase = secretv0alpha1.SecureValuePhasePending sv.Status.Message = "" + sv.Status.ExternalID = "" } } diff --git a/pkg/registry/apis/secret/reststorage/secure_value_rest_test.go b/pkg/registry/apis/secret/reststorage/secure_value_rest_test.go index 0671acee48a..3aa81b88d31 100644 --- a/pkg/registry/apis/secret/reststorage/secure_value_rest_test.go +++ b/pkg/registry/apis/secret/reststorage/secure_value_rest_test.go @@ -314,13 +314,15 @@ func TestSecureValueRestCreate(t *testing.T) { Description: "desc1", }, Status: secretv0alpha1.SecureValueStatus{ - Phase: secretv0alpha1.SecureValuePhasePending, + Phase: secretv0alpha1.SecureValuePhasePending, + ExternalID: "test-external-id", }, } sv.Spec.Value = secretv0alpha1.NewExposedSecureValue("v1") - _, err := sut.CreateSv(testutils.CreateSvWithSv(sv)) + createdSv, err := sut.CreateSv(testutils.CreateSvWithSv(sv)) require.NoError(t, err) + require.Empty(t, createdSv.Status.ExternalID) sv.Spec.Value = secretv0alpha1.NewExposedSecureValue("v2") _, err = sut.CreateSv(testutils.CreateSvWithSv(sv))