AccessControl: Add accesscontrol metadata to datasources DTOs (#42675)
* AccessControl: Provide scope to frontend * Covering datasources with accesscontrol metadata * Write benchmark tests for GetResourcesMetadata * Add accesscontrol util and interface * Add the hasPermissionInMetadata function in the frontend access control code * Use IsDisabled rather that performing a feature toggle check Co-authored-by: Karl Persson <kalle.persson@grafana.com>
This commit is contained in:
co-authored by
Karl Persson
parent
2b1ed43cb2
commit
c7cabdfd6f
@@ -0,0 +1,65 @@
|
||||
// go:build integration
|
||||
package accesscontrol
|
||||
|
||||
import (
|
||||
"context"
|
||||
"fmt"
|
||||
"testing"
|
||||
|
||||
"github.com/stretchr/testify/assert"
|
||||
"github.com/stretchr/testify/require"
|
||||
)
|
||||
|
||||
func setupTestEnv(b *testing.B, resourceCount, permissionPerResource int) ([]*Permission, map[string]bool) {
|
||||
res := make([]*Permission, resourceCount*permissionPerResource)
|
||||
ids := make(map[string]bool, resourceCount)
|
||||
|
||||
for r := 0; r < resourceCount; r++ {
|
||||
for p := 0; p < permissionPerResource; p++ {
|
||||
perm := Permission{Action: fmt.Sprintf("resources:action%v", p), Scope: fmt.Sprintf("resources:id:%v", r)}
|
||||
id := r*permissionPerResource + p
|
||||
res[id] = &perm
|
||||
}
|
||||
ids[fmt.Sprintf("%d", r)] = true
|
||||
}
|
||||
|
||||
return res, ids
|
||||
}
|
||||
|
||||
func benchGetMetadata(b *testing.B, resourceCount, permissionPerResource int) {
|
||||
permissions, ids := setupTestEnv(b, resourceCount, permissionPerResource)
|
||||
b.ResetTimer()
|
||||
|
||||
var metadata map[string]Metadata
|
||||
var err error
|
||||
for n := 0; n < b.N; n++ {
|
||||
metadata, err = GetResourcesMetadata(context.Background(), permissions, "resources", ids)
|
||||
require.NoError(b, err)
|
||||
assert.Len(b, metadata, resourceCount)
|
||||
for _, resourceMetadata := range metadata {
|
||||
assert.Len(b, resourceMetadata, permissionPerResource)
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
// Lots of permissions
|
||||
func BenchmarkGetResourcesMetadata_10_1000(b *testing.B) { benchGetMetadata(b, 10, 1000) } // ~0.0017s/op
|
||||
func BenchmarkGetResourcesMetadata_10_10000(b *testing.B) { benchGetMetadata(b, 10, 10000) } // ~0.016s/op
|
||||
func BenchmarkGetResourcesMetadata_10_100000(b *testing.B) { benchGetMetadata(b, 10, 100000) } // ~0.17s/op
|
||||
func BenchmarkGetResourcesMetadata_10_1000000(b *testing.B) {
|
||||
if testing.Short() {
|
||||
b.Skip("Skipping benchmark in short mode")
|
||||
}
|
||||
benchGetMetadata(b, 10, 1000000)
|
||||
} // ~3.89s/op
|
||||
|
||||
// Lots of resources (worst case)
|
||||
func BenchmarkGetResourcesMetadata_1000_10(b *testing.B) { benchGetMetadata(b, 1000, 10) } // ~0,0023s/op
|
||||
func BenchmarkGetResourcesMetadata_10000_10(b *testing.B) { benchGetMetadata(b, 10000, 10) } // ~0.021s/op
|
||||
func BenchmarkGetResourcesMetadata_100000_10(b *testing.B) { benchGetMetadata(b, 100000, 10) } // ~0.22s/op
|
||||
func BenchmarkGetResourcesMetadata_1000000_10(b *testing.B) {
|
||||
if testing.Short() {
|
||||
b.Skip("Skipping benchmark in short mode")
|
||||
}
|
||||
benchGetMetadata(b, 1000000, 10)
|
||||
} // ~2.8s/op
|
||||
Reference in New Issue
Block a user