public/grafana
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Plugins: Remove unnecessary error result from env vars interface (#73224)

Browse Source 
* remove error from interface

* fix test
This commit is contained in:
Will Browne
2023-08-14 14:17:54 +02:00
committed by GitHub
parent 16d24a8429
commit c830c01e61
4 changed files with 11 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkg/plugins/envvars/envvars.go
+3 -3
View File
@@ -16,7 +16,7 @@ import (
)
type Provider interface {
Get(ctx context.Context, p *plugins.Plugin) ([]string, error)
Get(ctx context.Context, p *plugins.Plugin) []string
}
type Service struct {
@@ -31,7 +31,7 @@ func NewProvider(cfg *config.Cfg, license plugins.Licensing) *Service {
}
}
func (s *Service) Get(ctx context.Context, p *plugins.Plugin) ([]string, error) {
func (s *Service) Get(_ context.Context, p *plugins.Plugin) []string {
hostEnv := []string{
fmt.Sprintf("GF_VERSION=%s", s.cfg.BuildVersion),
}
@@ -62,7 +62,7 @@ func (s *Service) Get(ctx context.Context, p *plugins.Plugin) ([]string, error)
hostEnv = append(hostEnv, s.tracingEnvVars(p)...)
ev := getPluginSettings(p.ID, s.cfg).asEnvVar("GF_PLUGIN", hostEnv)
return ev, nil
return ev
}
func (s *Service) tracingEnvVars(plugin *plugins.Plugin) []string {