diff --git a/public/app/core/components/json_explorer/helpers.ts b/public/app/core/components/json_explorer/helpers.ts index bc7468b3b21..c039d818281 100644 --- a/public/app/core/components/json_explorer/helpers.ts +++ b/public/app/core/components/json_explorer/helpers.ts @@ -21,7 +21,7 @@ export function isObject(value: any): boolean { * From http://stackoverflow.com/a/332429 * */ -export function getObjectName(object: Object): string { +export function getObjectName(object: object): string { if (object === undefined) { return ''; } @@ -44,7 +44,7 @@ export function getObjectName(object: Object): string { /* * Gets type of an object. Returns "null" for null objects */ -export function getType(object: Object): string { +export function getType(object: object): string { if (object === null) { return 'null'; } @@ -54,7 +54,7 @@ export function getType(object: Object): string { /* * Generates inline preview for a JavaScript object based on a value */ -export function getValuePreview(object: Object, value: string): string { +export function getValuePreview(object: object, value: string): string { const type = getType(object); if (type === 'null' || type === 'undefined') { @@ -79,15 +79,15 @@ export function getValuePreview(object: Object, value: string): string { /* * Generates inline preview for a JavaScript object */ -export function getPreview(object: string): string { - let value = ''; - if (isObject(object)) { - value = getObjectName(object); - if (Array.isArray(object)) { - value += '[' + object.length + ']'; +let value = ''; +export function getPreview(obj: object): string { + if (isObject(obj)) { + value = getObjectName(obj); + if (Array.isArray(obj)) { + value += '[' + obj.length + ']'; } } else { - value = getValuePreview(object, object); + value = getValuePreview(obj, obj.toString()); } return value; } diff --git a/public/app/features/dashboard/export_data/export_data_modal.ts b/public/app/features/dashboard/export_data/export_data_modal.ts index c384331963b..460f80079d9 100644 --- a/public/app/features/dashboard/export_data/export_data_modal.ts +++ b/public/app/features/dashboard/export_data/export_data_modal.ts @@ -5,9 +5,9 @@ import appEvents from 'app/core/app_events'; export class ExportDataModalCtrl { private data: any[]; private panel: string; - asRows: Boolean = true; + asRows = true; dateTimeFormat = 'YYYY-MM-DDTHH:mm:ssZ'; - excel: false; + excel = false; export() { if (this.panel === 'table') { diff --git a/tslint.json b/tslint.json index f9751452268..27ebab036d4 100644 --- a/tslint.json +++ b/tslint.json @@ -5,6 +5,12 @@ "ban": [true, {"name": "Array", "message": "tsstyle#array-constructor"} ], + "ban-types": [true, + ["Object", "Use {} instead."], + ["String", "Use 'string' instead."], + ["Number", "Use 'number' instead."], + ["Boolean", "Use 'boolean' instead."] + ], "interface-name": [true, "never-prefix"], "no-string-throw": true, "no-unused-expression": true,