From ca6281bc312d4a93096775ba6b82511fdd59d54e Mon Sep 17 00:00:00 2001 From: Ed Welch Date: Mon, 9 Dec 2024 09:01:22 -0500 Subject: [PATCH] Loki Expiremental Streaming: fixes nil check conditional which was accidentally inverted in a previous PR (#97612) --- pkg/tsdb/loki/streaming.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkg/tsdb/loki/streaming.go b/pkg/tsdb/loki/streaming.go index 29eb7be93a5..46c4d13eefd 100644 --- a/pkg/tsdb/loki/streaming.go +++ b/pkg/tsdb/loki/streaming.go @@ -34,7 +34,7 @@ func (s *Service) SubscribeStream(ctx context.Context, req *backend.SubscribeStr if err != nil { return nil, err } - if query.Expr != nil { + if query.Expr == nil || *query.Expr == "" { return &backend.SubscribeStreamResponse{ Status: backend.SubscribeStreamStatusNotFound, }, fmt.Errorf("missing expr in channel (subscribe)") @@ -69,7 +69,7 @@ func (s *Service) RunStream(ctx context.Context, req *backend.RunStreamRequest, if err != nil { return err } - if query.Expr != nil { + if query.Expr == nil || *query.Expr == "" { return fmt.Errorf("missing expr in cuannel") }