Unified Storage: Add ListSinceModified to StorageBackend (#109697)

* WIP added ListSinceModified to StorageBackend interface * fix compile time check * Fix method name * Fix naming * fix the rest of the ListSinceModified names * Uses resource key without name field * get latest rv from resource_version. Update test. * adds moar tests * adds method stub for ListModifiedSince to other StorageBackend implementations * adds dummy impl to noop storage backend for ListModifiedSince * skip tests for badger kv backend for now * fixes tests and adds badgerkv impl for ListModifiedSince * add badger kv impl * adds test for new query * adds test data for new query * adds ListModifiedSince stub to mockStorageBackend * uncomment tests * refactors ListModifiedSince to return an iter.seq2 and handles deduplication. Updates tests. Updates query result sorting. * remove comments * remove folder from query (dont need it, yet?) * regen test queries * updates test * updates function comment * use resourcepb.ResourceKey instead of ModifiedResourceKey * wrap seq in single transaction. Rollback transaction after 30s if iterator never used. Only track last seen event. Formatting. * skip TestListModifiedSince for kv backend * use WatchEvent_Type for action type * remove redundant fields from order by clause and regen test data for query * remove redundant fields from order by clause and regen test data for query
2025-08-20 11:54:31 -06:00
parent 49739618fa
commit cace999671
15 changed files with 329 additions and 19 deletions
@@ -30,24 +30,25 @@ func mustTemplate(filename string) *template.Template {

 // Templates.
 var (
-	sqlResourceDelete              = mustTemplate("resource_delete.sql")
-	sqlResourceInsert              = mustTemplate("resource_insert.sql")
-	sqlResourceUpdate              = mustTemplate("resource_update.sql")
-	sqlResourceRead                = mustTemplate("resource_read.sql")
-	sqlResourceStats               = mustTemplate("resource_stats.sql")
-	sqlResourceList                = mustTemplate("resource_list.sql")
-	sqlResourceHistoryList         = mustTemplate("resource_history_list.sql")
-	sqlResourceUpdateRV            = mustTemplate("resource_update_rv.sql")
-	sqlResourceHistoryRead         = mustTemplate("resource_history_read.sql")
-	sqlResourceHistoryReadLatestRV = mustTemplate("resource_history_read_latest_rv.sql")
-	sqlResourceHistoryUpdateRV     = mustTemplate("resource_history_update_rv.sql")
-	sqlResourceHistoryInsert       = mustTemplate("resource_history_insert.sql")
-	sqlResourceHistoryPoll         = mustTemplate("resource_history_poll.sql")
-	sqlResourceHistoryGet          = mustTemplate("resource_history_get.sql")
-	sqlResourceHistoryDelete       = mustTemplate("resource_history_delete.sql")
-	sqlResourceHistoryPrune        = mustTemplate("resource_history_prune.sql")
-	sqlResourceTrash               = mustTemplate("resource_trash.sql")
-	sqlResourceInsertFromHistory   = mustTemplate("resource_insert_from_history.sql")
+	sqlResourceDelete                   = mustTemplate("resource_delete.sql")
+	sqlResourceInsert                   = mustTemplate("resource_insert.sql")
+	sqlResourceUpdate                   = mustTemplate("resource_update.sql")
+	sqlResourceRead                     = mustTemplate("resource_read.sql")
+	sqlResourceStats                    = mustTemplate("resource_stats.sql")
+	sqlResourceList                     = mustTemplate("resource_list.sql")
+	sqlResourceHistoryList              = mustTemplate("resource_history_list.sql")
+	sqlResourceHistoryListModifiedSince = mustTemplate("resource_history_list_since_modified.sql")
+	sqlResourceUpdateRV                 = mustTemplate("resource_update_rv.sql")
+	sqlResourceHistoryRead              = mustTemplate("resource_history_read.sql")
+	sqlResourceHistoryReadLatestRV      = mustTemplate("resource_history_read_latest_rv.sql")
+	sqlResourceHistoryUpdateRV          = mustTemplate("resource_history_update_rv.sql")
+	sqlResourceHistoryInsert            = mustTemplate("resource_history_insert.sql")
+	sqlResourceHistoryPoll              = mustTemplate("resource_history_poll.sql")
+	sqlResourceHistoryGet               = mustTemplate("resource_history_get.sql")
+	sqlResourceHistoryDelete            = mustTemplate("resource_history_delete.sql")
+	sqlResourceHistoryPrune             = mustTemplate("resource_history_prune.sql")
+	sqlResourceTrash                    = mustTemplate("resource_trash.sql")
+	sqlResourceInsertFromHistory        = mustTemplate("resource_insert_from_history.sql")

 	// sqlResourceLabelsInsert = mustTemplate("resource_labels_insert.sql")
 	sqlResourceVersionGet    = mustTemplate("resource_version_get.sql")
@@ -425,3 +426,27 @@ func (r *sqlResourceVersionListRequest) Results() (*groupResourceVersion, error)
 	x := *r.groupResourceVersion
 	return &x, nil
 }
+
+type sqlResourceListModifiedSinceRequest struct {
+	sqltemplate.SQLTemplate
+	Namespace string
+	Group     string
+	Resource  string
+	SinceRv   int64
+}
+
+func (r sqlResourceListModifiedSinceRequest) Validate() error {
+	if r.Namespace == "" {
+		return fmt.Errorf("missing namespace")
+	}
+	if r.Group == "" {
+		return fmt.Errorf("missing group")
+	}
+	if r.Resource == "" {
+		return fmt.Errorf("missing resource")
+	}
+	if r.SinceRv < 0 {
+		return fmt.Errorf("since resource version must be greater than or equal to zero")
+	}
+	return nil
+}