From cd53070a007a9ba84cb40725f0cc3e9a25931f5c Mon Sep 17 00:00:00 2001 From: Josh Hunt Date: Thu, 27 Mar 2025 14:11:26 +0000 Subject: [PATCH] Update some translation markup on feedback from translators (#102702) --- public/app/core/components/help/HelpModal.tsx | 2 +- public/app/features/admin/ldap/LdapDrawer.tsx | 6 ++---- .../ModalAlerts/NoUpsertPermissionsAlert.tsx | 12 ++++++------ public/locales/en-US/grafana.json | 11 +++++------ 4 files changed, 14 insertions(+), 17 deletions(-) diff --git a/public/app/core/components/help/HelpModal.tsx b/public/app/core/components/help/HelpModal.tsx index a86afc947c0..edc0b4b37f1 100644 --- a/public/app/core/components/help/HelpModal.tsx +++ b/public/app/core/components/help/HelpModal.tsx @@ -130,7 +130,7 @@ const getShortcuts = (modKey: string) => { }, { keys: ['p', 's'], - description: t('help-modal.shortcuts-description.open-shared-modal', 'Open Panel Share Modal'), + description: t('help-modal.shortcuts-description.open-shared-modal', 'Share panel snapshot'), }, { keys: ['p', 'd'], description: t('help-modal.shortcuts-description.duplicate-panel', 'Duplicate Panel') }, { keys: ['p', 'r'], description: t('help-modal.shortcuts-description.remove-panel', 'Remove Panel') }, diff --git a/public/app/features/admin/ldap/LdapDrawer.tsx b/public/app/features/admin/ldap/LdapDrawer.tsx index 21e49aa725b..0bc896c7830 100644 --- a/public/app/features/admin/ldap/LdapDrawer.tsx +++ b/public/app/features/admin/ldap/LdapDrawer.tsx @@ -413,10 +413,8 @@ export const LdapDrawerComponent = ({ diff --git a/public/app/features/dashboard/components/ShareModal/SharePublicDashboard/ModalAlerts/NoUpsertPermissionsAlert.tsx b/public/app/features/dashboard/components/ShareModal/SharePublicDashboard/ModalAlerts/NoUpsertPermissionsAlert.tsx index ec925b916a5..d6801842ae8 100644 --- a/public/app/features/dashboard/components/ShareModal/SharePublicDashboard/ModalAlerts/NoUpsertPermissionsAlert.tsx +++ b/public/app/features/dashboard/components/ShareModal/SharePublicDashboard/ModalAlerts/NoUpsertPermissionsAlert.tsx @@ -9,24 +9,24 @@ export const NoUpsertPermissionsAlert = ({ mode }: { mode: 'create' | 'edit' }) const title = config.featureToggles.newDashboardSharingComponent ? t( 'public-dashboard.share-externally.no-upsert-perm-alert-title', - 'You don’t have permission to {{ mode }} a shared dashboard', - { mode } + 'You don’t have permission to {{ action }} a shared dashboard', + { action: mode } ) : t( 'public-dashboard.modal-alerts.no-upsert-perm-alert-title', - 'You don’t have permission to {{ mode }} a public dashboard', - { mode } + 'You don’t have permission to {{ action }} a public dashboard', + { action: mode } ); return ( {config.featureToggles.newDashboardSharingComponent ? ( - Contact your admin to get permission to {{ mode }} shared dashboards + Contact your admin to get permission to {{ action: mode }} shared dashboards ) : ( - Contact your admin to get permission to {{ mode }} public dashboards + Contact your admin to get permission to {{ action: mode }} public dashboards )} diff --git a/public/locales/en-US/grafana.json b/public/locales/en-US/grafana.json index 965ab9747db..9603556bc66 100644 --- a/public/locales/en-US/grafana.json +++ b/public/locales/en-US/grafana.json @@ -2950,7 +2950,7 @@ "move-time-range-back": "Move time range back", "move-time-range-forward": "Move time range forward", "open-search": "Open search", - "open-shared-modal": "Open Panel Share Modal", + "open-shared-modal": "Share panel snapshot", "paste-time-range": "Paste time range", "refresh-all-panels": "Refresh all panels", "remove-panel": "Remove Panel", @@ -3027,7 +3027,6 @@ }, "extra-security-section": { "client-cert-label": "Client certificate path", - "client-cert-placeholder": "/path/to/client_cert.pem", "client-cert-value-label": "Client certificate content", "client-cert-value-placeholder": "Client certificate content in base64", "client-key-label": "Client key path", @@ -4471,8 +4470,8 @@ "success-share-type-change": "Dashboard access updated: Only specific people can now access with the link" }, "modal-alerts": { - "no-upsert-perm-alert-desc": "Contact your admin to get permission to {{mode}} public dashboards", - "no-upsert-perm-alert-title": "You don’t have permission to {{ mode }} a public dashboard", + "no-upsert-perm-alert-desc": "Contact your admin to get permission to {{action}} public dashboards", + "no-upsert-perm-alert-title": "You don’t have permission to {{ action }} a public dashboard", "save-dashboard-changes-alert-title": "Please save your dashboard changes before updating the public configuration", "unsupport-data-source-alert-readmore-link": "Read more about supported data sources", "unsupported-data-source-alert-desc": "There are data sources in this dashboard that are unsupported for public dashboards. Panels that use these data sources may not function properly: {{unsupportedDataSources}}.", @@ -4519,8 +4518,8 @@ "copy-link-button": "Copy external link", "email-share-type-option-description": "Only people with the link can access dashboard", "email-share-type-option-label": "Only specific people", - "no-upsert-perm-alert-desc": "Contact your admin to get permission to {{mode}} shared dashboards", - "no-upsert-perm-alert-title": "You don’t have permission to {{ mode }} a shared dashboard", + "no-upsert-perm-alert-desc": "Contact your admin to get permission to {{action}} shared dashboards", + "no-upsert-perm-alert-title": "You don’t have permission to {{ action }} a shared dashboard", "pause-access-button": "Pause access", "pause-access-tooltip": "Pausing will temporarily disable access to this dashboard for all users", "public-share-type-option-description": "Anyone with the link can access dashboard",