public/grafana
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

proxyds: delete cookies except those listed in keepCookies

Browse Source
This commit is contained in:
Robin Gustafsson
2017-10-18 00:47:15 +02:00
committed by Daniel Lee
parent bcc85862fe
commit cf7a49977f
2 changed files with 20 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkg/api/pluginproxy/ds_proxy_test.go
+3 -5
View File
@@ -152,8 +152,7 @@ func TestDSRouteRule(t *testing.T) {
Convey("When proxying a data source with no keepCookies specified", func() {
plugin := &plugins.DataSourcePlugin{}
json := simplejson.New()
json.Set("keepCookies", []string{})
json, _ := simplejson.NewJson([]byte(`{"keepCookies": []}`))
ds := &m.DataSource{
Type: m.DS_GRAPHITE,
@@ -179,8 +178,7 @@ func TestDSRouteRule(t *testing.T) {
Convey("When proxying a data source with keep cookies specified", func() {
plugin := &plugins.DataSourcePlugin{}
json := simplejson.New()
json.Set("keepCookies", []string{"JSESSION_ID"})
json, _ := simplejson.NewJson([]byte(`{"keepCookies": ["JSESSION_ID"]}`))
ds := &m.DataSource{
Type: m.DS_GRAPHITE,
@@ -199,7 +197,7 @@ func TestDSRouteRule(t *testing.T) {
proxy.getDirector()(&req)
Convey("Should keep named cookies", func() {
So(req.Header.Get("Cookie"), ShouldEqual, "JSESSION=test")
So(req.Header.Get("Cookie"), ShouldEqual, "JSESSION_ID=test")
})
})