From d072718d1aa88f2ceb2dc2b22372462045144553 Mon Sep 17 00:00:00 2001 From: Marcus Andersson Date: Wed, 27 May 2020 14:51:15 +0200 Subject: [PATCH] Fix: make sure that we the gauge panel can handle scenario with no data. (#24938) * make sure that we can handle the empty data scenario in the gauge. * reverted Guague.tsx and set default values on no data. (cherry picked from commit f795a1577ca455f620f6fbf8a127e595888994b3) --- packages/grafana-data/src/field/fieldDisplay.test.ts | 12 ++++++++++++ packages/grafana-data/src/field/fieldDisplay.ts | 2 ++ 2 files changed, 14 insertions(+) diff --git a/packages/grafana-data/src/field/fieldDisplay.test.ts b/packages/grafana-data/src/field/fieldDisplay.test.ts index 73ad0d9f513..162d1a287f1 100644 --- a/packages/grafana-data/src/field/fieldDisplay.test.ts +++ b/packages/grafana-data/src/field/fieldDisplay.test.ts @@ -161,6 +161,18 @@ describe('FieldDisplay', () => { expect(display[0].display.numeric).toEqual(0); }); + it('Should always return defaults with min/max 0 when there is no data', () => { + const options = createEmptyDisplayOptions({ + fieldConfig: { + defaults: {}, + }, + }); + + const display = getFieldDisplayValues(options); + expect(display[0].field.min).toEqual(0); + expect(display[0].field.max).toEqual(0); + }); + describe('Value mapping', () => { it('should apply value mapping', () => { const mappingConfig = [ diff --git a/packages/grafana-data/src/field/fieldDisplay.ts b/packages/grafana-data/src/field/fieldDisplay.ts index ffc9bb4e287..087c488a999 100644 --- a/packages/grafana-data/src/field/fieldDisplay.ts +++ b/packages/grafana-data/src/field/fieldDisplay.ts @@ -275,6 +275,8 @@ function createNoValuesFieldDisplay(options: GetFieldDisplayValuesOptions): Fiel name: displayName, field: { ...defaults, + max: defaults.max ?? 0, + min: defaults.min ?? 0, }, display: { text,