From d074471557c4fbf09968dfa5b92f8d9d2d7b6a11 Mon Sep 17 00:00:00 2001 From: "Grot (@grafanabot)" <43478413+grafanabot@users.noreply.github.com> Date: Mon, 14 Nov 2022 03:54:58 -0500 Subject: [PATCH] [v9.2.x] Toolkit: Fix compilation loop when watching plugins for changes (#58695) Toolkit: Fix compilation loop when watching plugins for changes (#58167) * fix(toolkit): ignore node_modules and dist directories when watching for changes to plugin * fix(toolkit): move watchOptions.ignored config to pluginDev watch call (cherry picked from commit ce5040074058062e1777feafe2ad419af1f6a216) Co-authored-by: Jack Westbrook --- packages/grafana-toolkit/src/cli/tasks/plugin/bundle.ts | 3 +-- packages/grafana-toolkit/src/config/webpack.plugin.config.ts | 1 - 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/packages/grafana-toolkit/src/cli/tasks/plugin/bundle.ts b/packages/grafana-toolkit/src/cli/tasks/plugin/bundle.ts index 7d8b433403c..9743f402a63 100644 --- a/packages/grafana-toolkit/src/cli/tasks/plugin/bundle.ts +++ b/packages/grafana-toolkit/src/cli/tasks/plugin/bundle.ts @@ -22,9 +22,8 @@ export const bundlePlugin = async ({ watch, production, preserveConsole }: Plugi const webpackPromise = new Promise((resolve, reject) => { if (watch) { console.log('Started watching plugin for changes...'); - compiler.watch({}, (err, stats) => {}); + compiler.watch({ ignored: ['**/node_modules', '**/dist'] }, (err, stats) => {}); - // @ts-ignore compiler.hooks.invalid.tap('invalid', () => { clearConsole(); console.log('Compiling...'); diff --git a/packages/grafana-toolkit/src/config/webpack.plugin.config.ts b/packages/grafana-toolkit/src/config/webpack.plugin.config.ts index 7ba2d217d34..382c1e0b0a9 100644 --- a/packages/grafana-toolkit/src/config/webpack.plugin.config.ts +++ b/packages/grafana-toolkit/src/config/webpack.plugin.config.ts @@ -162,7 +162,6 @@ const getBaseWebpackConfig: WebpackConfigurationGetter = async (options) => { libraryTarget: 'amd', publicPath: '/', }, - performance: { hints: false }, externals: [ 'lodash',