Chore: Enable scopelint Go linter (#25896)

Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>

pkg/services/sqlstore/migrations/migrations_test.go

@@ -16,6 +16,7 @@ func TestMigrations(t *testing.T) {
 	}
 
 	for _, testDB := range testDBs {
+		testDB := testDB
 		sql := `select count(*) as count from migration_log`
 		r := struct {
 			Count int64

pkg/services/sqlstore/migrator/migrator.go

@@ -81,6 +81,7 @@ func (mg *Migrator) Start() error {
 	}
 
 	for _, m := range mg.migrations {
+		m := m
 		_, exists := logMap[m.Id()]
 		if exists {
 			mg.Logger.Debug("Skipping migration: Already executed", "id", m.Id())

pkg/services/sqlstore/sqlstore_test.go

@@ -71,6 +71,7 @@ func TestSqlConnectionString(t *testing.T) {
 		t.Helper()
 
 		for _, testCase := range sqlStoreTestCases {
+			testCase := testCase
 			Convey(testCase.name, func() {
 				sqlstore := &SqlStore{}
 				sqlstore.Cfg = makeSqlStoreTestConfig(testCase.dbType, testCase.dbHost)