From d34338be021149927652a8083713cc7f5c0eb272 Mon Sep 17 00:00:00 2001 From: Andres Martinez Gotor Date: Tue, 26 Aug 2025 16:03:34 +0200 Subject: [PATCH] Advisor: Avoid pagination when listing checks (#110161) --- apps/advisor/pkg/app/checkscheduler/checkscheduler.go | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/apps/advisor/pkg/app/checkscheduler/checkscheduler.go b/apps/advisor/pkg/app/checkscheduler/checkscheduler.go index 92fe70fe192..2b337239cb6 100644 --- a/apps/advisor/pkg/app/checkscheduler/checkscheduler.go +++ b/apps/advisor/pkg/app/checkscheduler/checkscheduler.go @@ -139,7 +139,9 @@ func (r *Runner) Run(ctx context.Context) error { } func (r *Runner) listChecks(ctx context.Context, logger logging.Logger) ([]resource.Object, error) { - list, err := r.client.List(ctx, r.namespace, resource.ListOptions{}) + list, err := r.client.List(ctx, r.namespace, resource.ListOptions{ + Limit: 1000, // Avoid pagination for normal uses cases, which is a costly operation + }) if err != nil { return nil, err } @@ -147,7 +149,7 @@ func (r *Runner) listChecks(ctx context.Context, logger logging.Logger) ([]resou checks := list.GetItems() for list.GetContinue() != "" { logger.Debug("List has continue token, listing next page", "continue", list.GetContinue()) - list, err = r.client.List(ctx, r.namespace, resource.ListOptions{Continue: list.GetContinue()}) + list, err = r.client.List(ctx, r.namespace, resource.ListOptions{Continue: list.GetContinue(), Limit: 1000}) if err != nil { return nil, err }