Chore: Move user errors to user service (#52460)

* Move user not found err to user service

* User ErrCaseInsensitive from user pkg

* User ErrUserAlreadyExists from user pkg

* User ErrLastGrafanaAdmin from user pkg

* Remove errors from model

pkg/services/user/userimpl/store.go

@@ -5,7 +5,6 @@ import (
 	"fmt"
 
 	"github.com/grafana/grafana/pkg/events"
-	"github.com/grafana/grafana/pkg/models"
 	"github.com/grafana/grafana/pkg/services/sqlstore"
 	"github.com/grafana/grafana/pkg/services/sqlstore/db"
 	"github.com/grafana/grafana/pkg/services/sqlstore/migrator"
@@ -52,7 +51,7 @@ func (ss *sqlStore) Get(ctx context.Context, usr *user.User) (*user.User, error)
 	err := ss.db.WithDbSession(ctx, func(sess *sqlstore.DBSession) error {
 		exists, err := sess.Where("email=? OR login=?", usr.Email, usr.Login).Get(usr)
 		if !exists {
-			return models.ErrUserNotFound
+			return user.ErrUserNotFound
 		}
 		if err != nil {
 			return err
@@ -78,18 +77,18 @@ func (ss *sqlStore) Delete(ctx context.Context, userID int64) error {
 }
 
 func (ss *sqlStore) GetNotServiceAccount(ctx context.Context, userID int64) (*user.User, error) {
-	user := user.User{ID: userID}
+	usr := user.User{ID: userID}
 	err := ss.db.WithDbSession(ctx, func(sess *sqlstore.DBSession) error {
-		has, err := sess.Where(ss.notServiceAccountFilter()).Get(&user)
+		has, err := sess.Where(ss.notServiceAccountFilter()).Get(&usr)
 		if err != nil {
 			return err
 		}
 		if !has {
-			return models.ErrUserNotFound
+			return user.ErrUserNotFound
 		}
 		return nil
 	})
-	return &user, err
+	return &usr, err
 }
 
 func (ss *sqlStore) notServiceAccountFilter() string {

pkg/services/user/userimpl/store_test.go

@@ -5,7 +5,6 @@ import (
 	"testing"
 	"time"
 
-	"github.com/grafana/grafana/pkg/models"
 	"github.com/grafana/grafana/pkg/services/sqlstore"
 	"github.com/grafana/grafana/pkg/services/user"
 
@@ -28,7 +27,7 @@ func TestIntegrationUserDataAccess(t *testing.T) {
 				Login: "test1",
 			},
 		)
-		require.Error(t, err, models.ErrUserNotFound)
+		require.Error(t, err, user.ErrUserNotFound)
 	})
 
 	t.Run("insert user", func(t *testing.T) {

pkg/services/user/userimpl/user.go

@@ -6,7 +6,6 @@ import (
 	"fmt"
 	"time"
 
-	"github.com/grafana/grafana/pkg/models"
 	"github.com/grafana/grafana/pkg/services/accesscontrol"
 	"github.com/grafana/grafana/pkg/services/dashboards"
 	"github.com/grafana/grafana/pkg/services/org"
@@ -84,7 +83,7 @@ func (s *Service) Create(ctx context.Context, cmd *user.CreateUserCommand) (*use
 		Email: cmd.Email,
 	}
 	usr, err = s.store.Get(ctx, usr)
-	if err != nil && !errors.Is(err, models.ErrUserNotFound) {
+	if err != nil && !errors.Is(err, user.ErrUserNotFound) {
 		return usr, err
 	}
 

pkg/services/user/userimpl/user_test.go

@@ -5,7 +5,6 @@ import (
 	"errors"
 	"testing"
 
-	"github.com/grafana/grafana/pkg/models"
 	"github.com/grafana/grafana/pkg/services/accesscontrol/mock"
 	"github.com/grafana/grafana/pkg/services/dashboards"
 	"github.com/grafana/grafana/pkg/services/org/orgtest"
@@ -46,12 +45,12 @@ func TestUserService(t *testing.T) {
 	})
 
 	t.Run("delete user store returns error", func(t *testing.T) {
-		userStore.ExpectedDeleteUserError = models.ErrUserNotFound
+		userStore.ExpectedDeleteUserError = user.ErrUserNotFound
 		t.Cleanup(func() {
 			userStore.ExpectedDeleteUserError = nil
 		})
 		err := userService.Delete(context.Background(), &user.DeleteUserCommand{UserID: 1})
-		require.Error(t, err, models.ErrUserNotFound)
+		require.Error(t, err, user.ErrUserNotFound)
 	})
 
 	t.Run("delete user returns from team", func(t *testing.T) {