Chore: Enable Go linter gocritic (#26224)

* Chore: Enable gocritic linter

Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>

pkg/components/dashdiffs/formatter_basic.go

@@ -212,12 +212,10 @@ func (b *BasicDiff) Basic(lines []*JSONLine) []*BasicBlock {
 					// - if we're not recording a change, then we do nothing,
 					// since the BasicDiff doesn't report on unchanged JSON
 					// values.
-				} else {
-					if b.writing {
-						b.writing = false
-						b.Summary.LineEnd = line.LineNum
-						b.Block.Summaries = append(b.Block.Summaries, b.Summary)
-					}
+				} else if b.writing {
+					b.writing = false
+					b.Summary.LineEnd = line.LineNum
+					b.Block.Summaries = append(b.Block.Summaries, b.Summary)
 				}
 			}
 		}