Chore: Enable Go linter gocritic (#26224)

* Chore: Enable gocritic linter

Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>

pkg/models/org_user.go

@@ -48,7 +48,7 @@ func (r *RoleType) UnmarshalJSON(data []byte) error {
 
 	*r = RoleType(str)
 
-	if !(*r).IsValid() {
+	if !r.IsValid() {
 		if (*r) != "" {
 			return fmt.Errorf("JSON validation error: invalid role value: %s", *r)
 		}

pkg/models/user.go

@@ -43,11 +43,11 @@ type User struct {
 func (u *User) NameOrFallback() string {
 	if u.Name != "" {
 		return u.Name
-	} else if u.Login != "" {
-		return u.Login
-	} else {
-		return u.Email
 	}
+	if u.Login != "" {
+		return u.Login
+	}
+	return u.Email
 }
 
 // ---------------------
@@ -192,11 +192,11 @@ func (u *SignedInUser) ShouldUpdateLastSeenAt() bool {
 func (u *SignedInUser) NameOrFallback() string {
 	if u.Name != "" {
 		return u.Name
-	} else if u.Login != "" {
-		return u.Login
-	} else {
-		return u.Email
 	}
+	if u.Login != "" {
+		return u.Login
+	}
+	return u.Email
 }
 
 type UpdateUserLastSeenAtCommand struct {