Chore: Enable Go linter gocritic (#26224)

* Chore: Enable gocritic linter Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
2020-07-16 14:39:01 +02:00
parent 317c7b269c
commit d4e4cb4c71
43 changed files with 184 additions and 171 deletions
@@ -395,11 +395,12 @@ func GetSignedInUser(query *models.GetSignedInUserQuery) error {
 		LEFT OUTER JOIN org on org.id = org_user.org_id `

 	sess := x.Table("user")
-	if query.UserId > 0 {
+	switch {
+	case query.UserId > 0:
 		sess.SQL(rawSql+"WHERE u.id=?", query.UserId)
-	} else if query.Login != "" {
+	case query.Login != "":
 		sess.SQL(rawSql+"WHERE u.login=?", query.Login)
-	} else if query.Email != "" {
+	case query.Email != "":
 		sess.SQL(rawSql+"WHERE u.email=?", query.Email)
 	}