Chore: Enable Go linter gocritic (#26224)

* Chore: Enable gocritic linter Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
2020-07-16 14:39:01 +02:00
parent 317c7b269c
commit d4e4cb4c71
43 changed files with 184 additions and 171 deletions
@@ -29,18 +29,21 @@ var credsCacheLock sync.RWMutex

 // Session factory.
 // Stubbable by tests.
+//nolint:gocritic
 var newSession = func(cfgs ...*aws.Config) (*session.Session, error) {
 	return session.NewSession(cfgs...)
 }

 // STS service factory.
 // Stubbable by tests.
+//nolint:gocritic
 var newSTSService = func(p client.ConfigProvider, cfgs ...*aws.Config) stsiface.STSAPI {
 	return sts.New(p, cfgs...)
 }

 // EC2Metadata service factory.
 // Stubbable by tests.
+//nolint:gocritic
 var newEC2Metadata = func(p client.ConfigProvider, cfgs ...*aws.Config) *ec2metadata.EC2Metadata {
 	return ec2metadata.New(p, cfgs...)
 }