From d673862853cd9b525ee901e170b5646dfa835c48 Mon Sep 17 00:00:00 2001 From: Kyle Cunningham Date: Wed, 4 Oct 2023 14:24:21 -0500 Subject: [PATCH] Transformations: Rename "Transform" tab to "Transform data" (#75757) * Rename transform tab to transform data --- .../geomap-spatial-operations-transform.spec.ts | 8 ++++---- e2e/panels-suite/panelEdit_base.spec.ts | 4 ++-- e2e/panels-suite/panelEdit_transforms.spec.ts | 2 +- .../components/PanelEditor/state/selectors.test.ts | 2 +- .../dashboard/components/PanelEditor/state/selectors.ts | 2 +- 5 files changed, 9 insertions(+), 9 deletions(-) diff --git a/e2e/panels-suite/geomap-spatial-operations-transform.spec.ts b/e2e/panels-suite/geomap-spatial-operations-transform.spec.ts index 7b9230d593a..79608bbce68 100644 --- a/e2e/panels-suite/geomap-spatial-operations-transform.spec.ts +++ b/e2e/panels-suite/geomap-spatial-operations-transform.spec.ts @@ -9,7 +9,7 @@ describe('Geomap spatial operations', () => { it('Tests location auto option', () => { e2e.flows.openDashboard({ uid: DASHBOARD_ID, queryParams: { editPanel: 1 } }); - e2e.components.Tab.title('Transform').should('be.visible').click(); + e2e.components.Tab.title('Transform data').should('be.visible').click(); e2e.components.TransformTab.newTransform('Spatial operations').scrollIntoView().should('be.visible').click(); e2e.components.Transforms.SpatialOperations.actionLabel().type('Prepare spatial field{enter}'); @@ -26,7 +26,7 @@ describe('Geomap spatial operations', () => { it('Tests location coords option', () => { e2e.flows.openDashboard({ uid: DASHBOARD_ID, queryParams: { editPanel: 1 } }); - e2e.components.Tab.title('Transform').should('be.visible').click(); + e2e.components.Tab.title('Transform data').should('be.visible').click(); e2e.components.TransformTab.newTransform('Spatial operations').scrollIntoView().should('be.visible').click(); e2e.components.Transforms.SpatialOperations.actionLabel().type('Prepare spatial field{enter}'); @@ -49,7 +49,7 @@ describe('Geomap spatial operations', () => { it('Tests geoshash field column appears in table view', () => { e2e.flows.openDashboard({ uid: DASHBOARD_ID, queryParams: { editPanel: 1 } }); - e2e.components.Tab.title('Transform').should('be.visible').click(); + e2e.components.Tab.title('Transform data').should('be.visible').click(); e2e.components.TransformTab.newTransform('Spatial operations').scrollIntoView().should('be.visible').click(); e2e.components.Transforms.SpatialOperations.actionLabel().type('Prepare spatial field{enter}'); @@ -71,7 +71,7 @@ describe('Geomap spatial operations', () => { it('Tests location lookup option', () => { e2e.flows.openDashboard({ uid: DASHBOARD_ID, queryParams: { editPanel: 1 } }); - e2e.components.Tab.title('Transform').should('be.visible').click(); + e2e.components.Tab.title('Transform data').should('be.visible').click(); e2e.components.TransformTab.newTransform('Spatial operations').scrollIntoView().should('be.visible').click(); e2e.components.Transforms.SpatialOperations.actionLabel().type('Prepare spatial field{enter}'); diff --git a/e2e/panels-suite/panelEdit_base.spec.ts b/e2e/panels-suite/panelEdit_base.spec.ts index 8f0703788f6..f3792dae532 100644 --- a/e2e/panels-suite/panelEdit_base.spec.ts +++ b/e2e/panels-suite/panelEdit_base.spec.ts @@ -35,9 +35,9 @@ describe('Panel edit tests', () => { // Bottom pane tabs // Can change to Transform tab - e2e.components.Tab.title('Transform').should('be.visible').click(); + e2e.components.Tab.title('Transform data').should('be.visible').click(); e2e.components.Tab.active().within((li: JQuery) => { - expect(li.text()).equals('Transform0'); // there's no transform so therefore Transform + 0 + expect(li.text()).equals('Transform data0'); // there's no transform so therefore Transform + 0 }); e2e.components.Transforms.card('Merge').scrollIntoView().should('be.visible'); e2e.components.QueryTab.content().should('not.exist'); diff --git a/e2e/panels-suite/panelEdit_transforms.spec.ts b/e2e/panels-suite/panelEdit_transforms.spec.ts index 46591eeb194..5cc191d000d 100644 --- a/e2e/panels-suite/panelEdit_transforms.spec.ts +++ b/e2e/panels-suite/panelEdit_transforms.spec.ts @@ -8,7 +8,7 @@ describe('Panel edit tests - transformations', () => { it('Tests transformations editor', () => { e2e.flows.openDashboard({ uid: '5SdHCadmz', queryParams: { editPanel: 3 } }); - e2e.components.Tab.title('Transform').should('be.visible').click(); + e2e.components.Tab.title('Transform data').should('be.visible').click(); e2e.components.TransformTab.newTransform('Reduce').scrollIntoView().should('be.visible').click(); e2e.components.Transforms.Reduce.calculationsLabel().should('be.visible'); }); diff --git a/public/app/features/dashboard/components/PanelEditor/state/selectors.test.ts b/public/app/features/dashboard/components/PanelEditor/state/selectors.test.ts index bb7c385e2d7..03e1685a997 100644 --- a/public/app/features/dashboard/components/PanelEditor/state/selectors.test.ts +++ b/public/app/features/dashboard/components/PanelEditor/state/selectors.test.ts @@ -34,7 +34,7 @@ describe('getPanelEditorTabs selector', () => { "active": true, "icon": "process", "id": "transform", - "text": "Transform", + "text": "Transform data", }, ] `); diff --git a/public/app/features/dashboard/components/PanelEditor/state/selectors.ts b/public/app/features/dashboard/components/PanelEditor/state/selectors.ts index 7627bcbcf07..02bde1dbaff 100644 --- a/public/app/features/dashboard/components/PanelEditor/state/selectors.ts +++ b/public/app/features/dashboard/components/PanelEditor/state/selectors.ts @@ -33,7 +33,7 @@ export const getPanelEditorTabs = memoizeOne((tab?: string, plugin?: PanelPlugin tabs.push({ id: PanelEditorTabId.Transform, - text: 'Transform', + text: 'Transform data', icon: 'process', active: false, });