[v11.3.x] CI: Support more version formats in publishing (#94750)

CI: Support more version formats in publishing (#94575)

* cleanup dead code
* add tests and rewrite publish grafanacom steps to reuse
* add pkg/build tests; don't upload CDN assets on grafana releases

(cherry picked from commit 7a2edd35d5)

pkg/build/env/lookup.go

@@ -1,18 +0,0 @@
-package env
-
-import (
-	"strings"
-)
-
-// Lookup is the equivalent of os.LookupEnv, only you are able to provide the list of environment variables.
-// To use this as os.LookupEnv would be used, simply call
-// `env.Lookup("ENVIRONMENT_VARIABLE", os.Environ())`
-func Lookup(name string, vars []string) (string, bool) {
-	for _, v := range vars {
-		if strings.HasPrefix(v, name) {
-			return strings.TrimPrefix(v, name+"="), true
-		}
-	}
-
-	return "", false
-}

pkg/build/env/lookup_test.go

@@ -1,43 +0,0 @@
-package env_test
-
-import (
-	"testing"
-
-	"github.com/stretchr/testify/require"
-
-	"github.com/grafana/grafana/pkg/build/env"
-)
-
-func TestLookup(t *testing.T) {
-	values := []string{"ENV_1=a", "ENV_2=b", "ENV_3=c", "ENV_4_TEST="}
-
-	{
-		v, ok := env.Lookup("ENV_1", values)
-		require.Equal(t, v, "a")
-		require.True(t, ok)
-	}
-
-	{
-		v, ok := env.Lookup("ENV_2", values)
-		require.Equal(t, v, "b")
-		require.True(t, ok)
-	}
-
-	{
-		v, ok := env.Lookup("ENV_3", values)
-		require.Equal(t, v, "c")
-		require.True(t, ok)
-	}
-
-	{
-		v, ok := env.Lookup("ENV_4_TEST", values)
-		require.Equal(t, v, "")
-		require.True(t, ok)
-	}
-
-	{
-		v, ok := env.Lookup("NOT_THERE", values)
-		require.Equal(t, v, "")
-		require.False(t, ok)
-	}
-}