Nested Folders: Fix /api/folders pagination (#79447)
* Nested Folders: Fix /api/folders pagination We used to check access to the root folders after fetching them from the DB with pagination. This fix splits logic for fetching folders in: - fetching subfolders - fetching root folders and refactors the query for the latter so that is filters by folders with permissions * Add tests * Update benchmarks
This commit is contained in:
Sofia Papagiannaki
@@ -0,0 +1,199 @@
|
||||
package folders
|
||||
|
||||
import (
|
||||
"context"
|
||||
"fmt"
|
||||
"net/http"
|
||||
"runtime"
|
||||
"testing"
|
||||
|
||||
"github.com/grafana/dskit/concurrency"
|
||||
"github.com/grafana/grafana-openapi-client-go/client/folders"
|
||||
"github.com/grafana/grafana-openapi-client-go/models"
|
||||
"github.com/grafana/grafana/pkg/services/accesscontrol/resourcepermissions"
|
||||
"github.com/grafana/grafana/pkg/services/featuremgmt"
|
||||
"github.com/grafana/grafana/pkg/services/folder"
|
||||
"github.com/grafana/grafana/pkg/services/org"
|
||||
"github.com/grafana/grafana/pkg/services/user"
|
||||
"github.com/grafana/grafana/pkg/tests"
|
||||
"github.com/grafana/grafana/pkg/tests/testinfra"
|
||||
"github.com/stretchr/testify/assert"
|
||||
"github.com/stretchr/testify/require"
|
||||
)
|
||||
|
||||
func TestGetFolders(t *testing.T) {
|
||||
// Setup Grafana and its Database
|
||||
dir, p := testinfra.CreateGrafDir(t, testinfra.GrafanaOpts{
|
||||
DisableLegacyAlerting: true,
|
||||
EnableUnifiedAlerting: true,
|
||||
DisableAnonymous: true,
|
||||
AppModeProduction: true,
|
||||
EnableFeatureToggles: []string{featuremgmt.FlagNestedFolders},
|
||||
})
|
||||
|
||||
grafanaListedAddr, store := testinfra.StartGrafana(t, dir, p)
|
||||
|
||||
orgID := int64(1)
|
||||
|
||||
// Create a users to make authenticated requests
|
||||
tests.CreateUser(t, store, user.CreateUserCommand{
|
||||
DefaultOrgRole: string(org.RoleViewer),
|
||||
OrgID: orgID,
|
||||
Password: "viewer",
|
||||
Login: "viewer",
|
||||
})
|
||||
tests.CreateUser(t, store, user.CreateUserCommand{
|
||||
OrgID: orgID,
|
||||
DefaultOrgRole: string(org.RoleEditor),
|
||||
Password: "editor",
|
||||
Login: "editor",
|
||||
})
|
||||
tests.CreateUser(t, store, user.CreateUserCommand{
|
||||
OrgID: orgID,
|
||||
DefaultOrgRole: string(org.RoleAdmin),
|
||||
Password: "admin",
|
||||
Login: "admin",
|
||||
})
|
||||
|
||||
adminClient := tests.GetClient(grafanaListedAddr, "admin", "admin")
|
||||
editorClient := tests.GetClient(grafanaListedAddr, "editor", "editor")
|
||||
viewerClient := tests.GetClient(grafanaListedAddr, "viewer", "viewer")
|
||||
|
||||
// access control permissions store
|
||||
permissionsStore := resourcepermissions.NewStore(store, featuremgmt.WithFeatures())
|
||||
|
||||
numberOfFolders := 5
|
||||
indexWithoutPermission := 3
|
||||
err := concurrency.ForEachJob(context.Background(), numberOfFolders, runtime.NumCPU(), func(_ context.Context, job int) error {
|
||||
resp, err := adminClient.Folders.CreateFolder(&models.CreateFolderCommand{
|
||||
Title: fmt.Sprintf("Folder %d", job),
|
||||
UID: fmt.Sprintf("folder-%d", job),
|
||||
})
|
||||
if err != nil {
|
||||
return err
|
||||
}
|
||||
require.Equal(t, http.StatusOK, resp.Code())
|
||||
if job == indexWithoutPermission {
|
||||
tests.RemoveFolderPermission(t, permissionsStore, orgID, org.RoleViewer, resp.Payload.UID)
|
||||
t.Log("Removed viewer permission from folder", resp.Payload.UID)
|
||||
}
|
||||
return nil
|
||||
})
|
||||
require.NoError(t, err)
|
||||
|
||||
t.Run("Admin can get all folders", func(t *testing.T) {
|
||||
res, err := adminClient.Folders.GetFolders(folders.NewGetFoldersParams())
|
||||
require.NoError(t, err)
|
||||
actualFolders := make([]string, 0, len(res.Payload))
|
||||
for i := range res.Payload {
|
||||
actualFolders = append(actualFolders, res.Payload[i].UID)
|
||||
}
|
||||
assert.Equal(t, []string{"folder-0", "folder-1", "folder-2", "folder-3", "folder-4"}, actualFolders)
|
||||
})
|
||||
|
||||
t.Run("Pagination works as expect for admin", func(t *testing.T) {
|
||||
limit := int64(2)
|
||||
page := int64(1)
|
||||
res, err := adminClient.Folders.GetFolders(folders.NewGetFoldersParams().WithLimit(&limit).WithPage(&page))
|
||||
require.NoError(t, err)
|
||||
actualFolders := make([]string, 0, len(res.Payload))
|
||||
for i := range res.Payload {
|
||||
actualFolders = append(actualFolders, res.Payload[i].UID)
|
||||
}
|
||||
assert.Equal(t, []string{"folder-0", "folder-1"}, actualFolders)
|
||||
|
||||
page = int64(2)
|
||||
res, err = adminClient.Folders.GetFolders(folders.NewGetFoldersParams().WithLimit(&limit).WithPage(&page))
|
||||
require.NoError(t, err)
|
||||
actualFolders = make([]string, 0, len(res.Payload))
|
||||
for i := range res.Payload {
|
||||
actualFolders = append(actualFolders, res.Payload[i].UID)
|
||||
}
|
||||
assert.Equal(t, []string{"folder-2", "folder-3"}, actualFolders)
|
||||
|
||||
page = int64(3)
|
||||
res, err = adminClient.Folders.GetFolders(folders.NewGetFoldersParams().WithLimit(&limit).WithPage(&page))
|
||||
require.NoError(t, err)
|
||||
actualFolders = make([]string, 0, len(res.Payload))
|
||||
for i := range res.Payload {
|
||||
actualFolders = append(actualFolders, res.Payload[i].UID)
|
||||
}
|
||||
assert.Equal(t, []string{"folder-4"}, actualFolders)
|
||||
})
|
||||
|
||||
t.Run("Editor can get all folders", func(t *testing.T) {
|
||||
res, err := editorClient.Folders.GetFolders(folders.NewGetFoldersParams())
|
||||
require.NoError(t, err)
|
||||
actualFolders := make([]string, 0, len(res.Payload))
|
||||
for i := range res.Payload {
|
||||
actualFolders = append(actualFolders, res.Payload[i].UID)
|
||||
}
|
||||
assert.Equal(t, []string{"folder-0", "folder-1", "folder-2", "folder-3", "folder-4", folder.SharedWithMeFolderUID}, actualFolders)
|
||||
})
|
||||
|
||||
t.Run("Pagination works as expect for editor", func(t *testing.T) {
|
||||
limit := int64(2)
|
||||
page := int64(1)
|
||||
res, err := editorClient.Folders.GetFolders(folders.NewGetFoldersParams().WithLimit(&limit).WithPage(&page))
|
||||
require.NoError(t, err)
|
||||
actualFolders := make([]string, 0, len(res.Payload))
|
||||
for i := range res.Payload {
|
||||
actualFolders = append(actualFolders, res.Payload[i].UID)
|
||||
}
|
||||
assert.Equal(t, []string{"folder-0", "folder-1", folder.SharedWithMeFolderUID}, actualFolders)
|
||||
|
||||
page = int64(2)
|
||||
res, err = editorClient.Folders.GetFolders(folders.NewGetFoldersParams().WithLimit(&limit).WithPage(&page))
|
||||
require.NoError(t, err)
|
||||
actualFolders = make([]string, 0, len(res.Payload))
|
||||
for i := range res.Payload {
|
||||
actualFolders = append(actualFolders, res.Payload[i].UID)
|
||||
}
|
||||
assert.Equal(t, []string{"folder-2", "folder-3"}, actualFolders)
|
||||
|
||||
page = int64(3)
|
||||
res, err = editorClient.Folders.GetFolders(folders.NewGetFoldersParams().WithLimit(&limit).WithPage(&page))
|
||||
require.NoError(t, err)
|
||||
actualFolders = make([]string, 0, len(res.Payload))
|
||||
for i := range res.Payload {
|
||||
actualFolders = append(actualFolders, res.Payload[i].UID)
|
||||
}
|
||||
assert.Equal(t, []string{"folder-4"}, actualFolders)
|
||||
})
|
||||
|
||||
t.Run("Viewer can get only the folders has access too", func(t *testing.T) {
|
||||
res, err := viewerClient.Folders.GetFolders(folders.NewGetFoldersParams())
|
||||
require.NoError(t, err)
|
||||
actualFolders := make([]string, 0, len(res.Payload))
|
||||
for i := range res.Payload {
|
||||
actualFolders = append(actualFolders, res.Payload[i].UID)
|
||||
}
|
||||
assert.Equal(t, []string{"folder-0", "folder-1", "folder-2", "folder-4", folder.SharedWithMeFolderUID}, actualFolders)
|
||||
})
|
||||
|
||||
t.Run("Pagination works as expect for viewer", func(t *testing.T) {
|
||||
limit := int64(2)
|
||||
page := int64(1)
|
||||
res, err := viewerClient.Folders.GetFolders(folders.NewGetFoldersParams().WithLimit(&limit).WithPage(&page))
|
||||
require.NoError(t, err)
|
||||
actualFolders := make([]string, 0, len(res.Payload))
|
||||
for i := range res.Payload {
|
||||
actualFolders = append(actualFolders, res.Payload[i].UID)
|
||||
}
|
||||
assert.Equal(t, []string{"folder-0", "folder-1", folder.SharedWithMeFolderUID}, actualFolders)
|
||||
|
||||
page = int64(2)
|
||||
res, err = viewerClient.Folders.GetFolders(folders.NewGetFoldersParams().WithLimit(&limit).WithPage(&page))
|
||||
require.NoError(t, err)
|
||||
actualFolders = make([]string, 0, len(res.Payload))
|
||||
for i := range res.Payload {
|
||||
actualFolders = append(actualFolders, res.Payload[i].UID)
|
||||
}
|
||||
assert.Equal(t, []string{"folder-2", "folder-4"}, actualFolders)
|
||||
|
||||
page = int64(3)
|
||||
res, err = viewerClient.Folders.GetFolders(folders.NewGetFoldersParams().WithLimit(&limit).WithPage(&page))
|
||||
require.NoError(t, err)
|
||||
assert.Len(t, res.Payload, 0)
|
||||
})
|
||||
}
|
||||
Reference in New Issue
Block a user