Plugins: Remove old code related to Core plugin installs (#44311)

* remove old code

* remove even more

* skip flaky test

pkg/plugins/manager/loader/initializer/initializer.go

@@ -11,7 +11,6 @@ import (
 	"github.com/grafana/grafana/pkg/infra/log"
 	"github.com/grafana/grafana/pkg/models"
 	"github.com/grafana/grafana/pkg/plugins"
-	"github.com/grafana/grafana/pkg/plugins/backendplugin"
 )
 
 type Initializer struct {
@@ -47,21 +46,6 @@ func (i *Initializer) Initialize(ctx context.Context, p *plugins.Plugin) error {
 	return nil
 }
 
-func (i *Initializer) InitializeWithFactory(p *plugins.Plugin, factory backendplugin.PluginFactoryFunc) error {
-	if factory == nil {
-		return fmt.Errorf("could not initialize plugin %s", p.ID)
-	}
-
-	f, err := factory(p.ID, log.New("pluginID", p.ID), []string{})
-	if err != nil {
-		return err
-	}
-
-	p.RegisterClient(f)
-
-	return nil
-}
-
 func (i *Initializer) envVars(plugin *plugins.Plugin) []string {
 	hostEnv := []string{
 		fmt.Sprintf("GF_VERSION=%s", i.cfg.BuildVersion),

pkg/plugins/manager/loader/initializer/initializer_test.go

@@ -103,49 +103,6 @@ func TestInitializer_Initialize(t *testing.T) {
 	})
 }
 
-func TestInitializer_InitializeWithFactory(t *testing.T) {
-	t.Run("happy path", func(t *testing.T) {
-		p := &plugins.Plugin{}
-		i := &Initializer{
-			cfg: &plugins.Cfg{},
-			log: fakeLogger{},
-		}
-
-		factoryInvoked := false
-
-		factory := backendplugin.PluginFactoryFunc(func(pluginID string, logger log.Logger, env []string) (backendplugin.Plugin, error) {
-			factoryInvoked = true
-			return testPlugin{}, nil
-		})
-
-		err := i.InitializeWithFactory(p, factory)
-		assert.NoError(t, err)
-
-		assert.True(t, factoryInvoked)
-		client, exists := p.Client()
-		assert.True(t, exists)
-		assert.NotNil(t, client.(testPlugin))
-	})
-
-	t.Run("invalid factory", func(t *testing.T) {
-		p := &plugins.Plugin{}
-		i := &Initializer{
-			cfg: &plugins.Cfg{},
-			log: fakeLogger{},
-			backendProvider: &fakeBackendProvider{
-				plugin: p,
-			},
-		}
-
-		err := i.InitializeWithFactory(p, nil)
-		assert.Errorf(t, err, "could not initialize plugin test-plugin")
-
-		c, exists := p.Client()
-		assert.False(t, exists)
-		assert.Nil(t, c)
-	})
-}
-
 func TestInitializer_envVars(t *testing.T) {
 	t.Run("backend datasource with license", func(t *testing.T) {
 		p := &plugins.Plugin{
@@ -254,10 +211,6 @@ func (*testLicensingService) FeatureEnabled(feature string) bool {
 	return false
 }
 
-type testPlugin struct {
-	backendplugin.Plugin
-}
-
 type fakeLogger struct {
 	log.MultiLoggers
 }