diff --git a/public/app/plugins/datasource/tempo/SearchTraceQLEditor/GroupByField.test.tsx b/public/app/plugins/datasource/tempo/SearchTraceQLEditor/GroupByField.test.tsx index 9c010e7057e..af230d44ecf 100644 --- a/public/app/plugins/datasource/tempo/SearchTraceQLEditor/GroupByField.test.tsx +++ b/public/app/plugins/datasource/tempo/SearchTraceQLEditor/GroupByField.test.tsx @@ -63,6 +63,7 @@ describe('GroupByField', () => { const groupByFilter = query.groupBy?.find((f) => f.id === 'group-by-id'); expect(groupByFilter).not.toBeNull(); expect(groupByFilter?.scope).toBe('resource'); + expect(groupByFilter?.tag).toBe(''); } }); diff --git a/public/app/plugins/datasource/tempo/SearchTraceQLEditor/GroupByField.tsx b/public/app/plugins/datasource/tempo/SearchTraceQLEditor/GroupByField.tsx index 2fb1682bcba..93768010da0 100644 --- a/public/app/plugins/datasource/tempo/SearchTraceQLEditor/GroupByField.tsx +++ b/public/app/plugins/datasource/tempo/SearchTraceQLEditor/GroupByField.tsx @@ -78,44 +78,45 @@ export const GroupByField = (props: Props) => {
{ + updateFilter({ ...f, tag: v?.value }); + }} options={getTags(f)?.map((t) => ({ label: t, value: t, }))} - value={f.tag || ''} - onChange={(v) => { - updateFilter({ ...f, tag: v?.value }); - }} placeholder="Select tag" - aria-label={`Select tag for filter ${i + 1}`} - isLoading={isTagsLoading} - isClearable + value={f.tag || ''} /> removeFilter(f)} tooltip="Remove tag" - aria-label={`Remove tag for filter ${i + 1}`} + variant="secondary" /> {i === (query.groupBy?.length ?? 0) - 1 && ( addFilter()} tooltip="Add tag" - aria-label="Add tag" + variant="secondary" /> )}