diff --git a/e2e/suite1/specs/exemplars.spec.ts b/e2e/suite1/specs/exemplars.spec.ts index 89165047f9c..29ad989294c 100644 --- a/e2e/suite1/specs/exemplars.spec.ts +++ b/e2e/suite1/specs/exemplars.spec.ts @@ -12,7 +12,7 @@ const addDataSource = () => { e2e.components.DataSourcePicker.container() .should('be.visible') .within(() => { - e2e.components.Select.input().should('be.visible').click({ force: true }); + e2e.components.DataSourcePicker.input().should('be.visible').click({ force: true }); }); e2e().contains('gdev-tempo').scrollIntoView().should('be.visible').click(); @@ -53,7 +53,7 @@ describe('Exemplars', () => { e2e.components.DataSourcePicker.container() .should('be.visible') .within(() => { - e2e.components.Select.input().should('be.visible').click(); + e2e.components.DataSourcePicker.input().should('be.visible').click(); }); e2e().contains(dataSourceName).scrollIntoView().should('be.visible').click(); e2e.components.TimePicker.openButton().click(); diff --git a/e2e/suite1/specs/query-editor.spec.ts b/e2e/suite1/specs/query-editor.spec.ts index 3b5518e2362..ccb66ba5fa6 100644 --- a/e2e/suite1/specs/query-editor.spec.ts +++ b/e2e/suite1/specs/query-editor.spec.ts @@ -11,7 +11,7 @@ e2e.scenario({ e2e.components.DataSourcePicker.container() .should('be.visible') .within(() => { - e2e.components.Select.input().should('be.visible').click(); + e2e.components.DataSourcePicker.input().should('be.visible').click(); }); cy.contains('gdev-prometheus').scrollIntoView().should('be.visible').click(); diff --git a/e2e/suite1/specs/templating-dashboard-links-and-variables.ts b/e2e/suite1/specs/templating-dashboard-links-and-variables.ts index 62c1c86ab39..bf6782e2d64 100644 --- a/e2e/suite1/specs/templating-dashboard-links-and-variables.ts +++ b/e2e/suite1/specs/templating-dashboard-links-and-variables.ts @@ -50,8 +50,11 @@ e2e.scenario({ e2e.pages.Dashboard.SubMenu.submenuItemValueDropDownOptionTexts('p2').should('be.visible').click(); e2e.components.PageToolbar.container().click(); - - e2e.components.DashboardLinks.dropDown().should('be.visible').click().wait('@tagsTemplatingSearch'); + e2e.components.DashboardLinks.dropDown() + .scrollIntoView() + .should('be.visible') + .click() + .wait('@tagsTemplatingSearch'); // verify all links, should have p2 value verifyLinks('p2'); diff --git a/e2e/suite1/specs/trace-view-scrolling.spec.ts b/e2e/suite1/specs/trace-view-scrolling.spec.ts index c55444c2bfe..b8c1c3ac0f1 100644 --- a/e2e/suite1/specs/trace-view-scrolling.spec.ts +++ b/e2e/suite1/specs/trace-view-scrolling.spec.ts @@ -14,7 +14,7 @@ describe('Trace view', () => { e2e.components.DataSourcePicker.container() .should('be.visible') .within(() => { - e2e.components.Select.input().should('be.visible').click(); + e2e.components.DataSourcePicker.input().should('be.visible').click(); }); e2e().contains('gdev-jaeger').scrollIntoView().should('be.visible').click(); diff --git a/e2e/suite1/specs/variables/new-query-variable.ts b/e2e/suite1/specs/variables/new-query-variable.ts index d214b224c81..3ff190a1fe9 100644 --- a/e2e/suite1/specs/variables/new-query-variable.ts +++ b/e2e/suite1/specs/variables/new-query-variable.ts @@ -85,7 +85,7 @@ describe('Variables - Add variable', () => { e2e.pages.Dashboard.Settings.Variables.Edit.QueryVariable.queryOptionsDataSourceSelect() .should('be.visible') .within(() => { - e2e.components.Select.input().should('be.visible').type('gdev-testdata').type('{enter}'); + e2e.components.DataSourcePicker.input().should('be.visible').type('gdev-testdata').type('{enter}'); }); e2e.pages.Dashboard.Settings.Variables.Edit.QueryVariable.queryOptionsQueryInput() @@ -139,7 +139,7 @@ describe('Variables - Add variable', () => { e2e.pages.Dashboard.Settings.Variables.Edit.QueryVariable.queryOptionsDataSourceSelect() .should('be.visible') .within(() => { - e2e.components.Select.input().should('be.visible').type('gdev-testdata').type('{enter}'); + e2e.components.DataSourcePicker.input().should('be.visible').type('gdev-testdata').type('{enter}'); }); e2e.pages.Dashboard.Settings.Variables.Edit.QueryVariable.queryOptionsQueryInput() diff --git a/packages/grafana-data/src/themes/createColors.ts b/packages/grafana-data/src/themes/createColors.ts index d0f34a46a81..aaee1dc9a71 100644 --- a/packages/grafana-data/src/themes/createColors.ts +++ b/packages/grafana-data/src/themes/createColors.ts @@ -96,7 +96,7 @@ class DarkColors implements ThemeColorsBase> { text = { primary: `rgb(${this.whiteBase})`, secondary: `rgba(${this.whiteBase}, 0.65)`, - disabled: `rgba(${this.whiteBase}, 0.40)`, + disabled: `rgba(${this.whiteBase}, 0.57)`, link: palette.blueDarkText, maxContrast: palette.white, }; diff --git a/packages/grafana-e2e-selectors/src/selectors/components.ts b/packages/grafana-e2e-selectors/src/selectors/components.ts index 0b4e9c20a37..99d3016c585 100644 --- a/packages/grafana-e2e-selectors/src/selectors/components.ts +++ b/packages/grafana-e2e-selectors/src/selectors/components.ts @@ -202,6 +202,7 @@ export const Components = { }, DataSourcePicker: { container: 'Data source picker select container', + input: () => 'input[id="data-source-picker"]', }, TimeZonePicker: { container: 'Time zone picker select container', diff --git a/packages/grafana-runtime/src/components/DataSourcePicker.tsx b/packages/grafana-runtime/src/components/DataSourcePicker.tsx index a95c9bf8a56..4dd5bac238b 100644 --- a/packages/grafana-runtime/src/components/DataSourcePicker.tsx +++ b/packages/grafana-runtime/src/components/DataSourcePicker.tsx @@ -145,6 +145,7 @@ export class DataSourcePicker extends PureComponent