From ddd826616bda5f5b968c40e860892fba6948a72f Mon Sep 17 00:00:00 2001 From: bergquist Date: Mon, 25 Apr 2016 16:38:27 +0200 Subject: [PATCH] feat(alerting): serialize whole target obj from dashboard --- pkg/models/alerts.go | 5 ++++- pkg/models/alerts_test.go | 2 +- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/pkg/models/alerts.go b/pkg/models/alerts.go index 1035509b23c..716bff161f4 100644 --- a/pkg/models/alerts.go +++ b/pkg/models/alerts.go @@ -57,7 +57,10 @@ func (cmd *SaveDashboardCommand) GetAlertModels() *[]AlertRule { target := simplejson.NewFromAny(targetsObj) if target.Get("refId").MustString() == alert.QueryRefId { - alert.Query = target.Get("target").MustString() + targetJson, err := target.MarshalJSON() + if err == nil { + alert.Query = string(targetJson) + } continue } } diff --git a/pkg/models/alerts_test.go b/pkg/models/alerts_test.go index 3f0870d3e63..b3dcffea4cf 100644 --- a/pkg/models/alerts_test.go +++ b/pkg/models/alerts_test.go @@ -287,7 +287,7 @@ func TestAlertModel(t *testing.T) { fmt.Println(v.Query) } - So(alerts[0].Query, ShouldEqual, "statsd.fakesite.counters.session_start.desktop.count") + So(alerts[0].Query, ShouldEqual, "{\"hide\":false,\"refId\":\"A\",\"target\":\"statsd.fakesite.counters.session_start.desktop.count\"}") }) }) }