Tempo: Remove aggregate by (#98474)

* Remove aggregate by

* Update betterer

* Run toggles test

* Add back group by in schema so it can be checked for

* Show error if group by

* Update error message

* Allow user to remove the group by from the query

* Fix assertion

---------

Co-authored-by: Piotr Jamróz <pm.jamroz@gmail.com>

pkg/services/featuremgmt/registry.go

@@ -441,13 +441,6 @@ var (
 			Owner:        grafanaObservabilityTracesAndProfilingSquad,
 			Expression:   "false",
 		},
-		{
-			Name:         "metricsSummary",
-			Description:  "Enables metrics summary queries in the Tempo data source",
-			Stage:        FeatureStageExperimental,
-			FrontendOnly: true,
-			Owner:        grafanaObservabilityTracesAndProfilingSquad,
-		},
 		{
 			Name:            "datasourceAPIServers",
 			Description:     "Expose some datasources as apiservers.",

pkg/services/featuremgmt/toggles_gen.csv

@@ -58,7 +58,6 @@ awsDatasourcesTempCredentials,experimental,@grafana/aws-datasources,false,false,
 transformationsRedesign,GA,@grafana/observability-metrics,false,false,true
 mlExpressions,experimental,@grafana/alerting-squad,false,false,false
 traceQLStreaming,GA,@grafana/observability-traces-and-profiling,false,false,true
-metricsSummary,experimental,@grafana/observability-traces-and-profiling,false,false,true
 datasourceAPIServers,experimental,@grafana/grafana-app-platform-squad,false,true,false
 grafanaAPIServerWithExperimentalAPIs,experimental,@grafana/grafana-app-platform-squad,true,true,false
 provisioning,experimental,@grafana/grafana-app-platform-squad,false,true,false

pkg/services/featuremgmt/toggles_gen.go

@@ -243,10 +243,6 @@ const (
 	// Enables response streaming of TraceQL queries of the Tempo data source
 	FlagTraceQLStreaming = "traceQLStreaming"
 
-	// FlagMetricsSummary
-	// Enables metrics summary queries in the Tempo data source
-	FlagMetricsSummary = "metricsSummary"
-
 	// FlagDatasourceAPIServers
 	// Expose some datasources as apiservers.
 	FlagDatasourceAPIServers = "datasourceAPIServers"

pkg/services/featuremgmt/toggles_gen.json

@@ -2768,7 +2768,8 @@
       "metadata": {
         "name": "metricsSummary",
         "resourceVersion": "1718727528075",
-        "creationTimestamp": "2023-08-28T14:02:12Z"
+        "creationTimestamp": "2023-08-28T14:02:12Z",
+        "deletionTimestamp": "2024-11-25T10:47:18Z"
       },
       "spec": {
         "description": "Enables metrics summary queries in the Tempo data source",