Simplify open feature setup (#107632)
* Simplify open feature setup * Fix linter issues * Apply review feedback * Fix integration tests setup
This commit is contained in:
@@ -37,7 +37,6 @@ type ServiceImpl struct {
|
||||
pluginSettings pluginsettings.Service
|
||||
starService star.Service
|
||||
features featuremgmt.FeatureToggles
|
||||
openFeature *featuremgmt.OpenFeatureService
|
||||
dashboardService dashboards.DashboardService
|
||||
accesscontrolService ac.Service
|
||||
kvStore kvstore.KVStore
|
||||
@@ -60,7 +59,7 @@ type NavigationAppConfig struct {
|
||||
|
||||
func ProvideService(cfg *setting.Cfg, accessControl ac.AccessControl, pluginStore pluginstore.Store, pluginSettings pluginsettings.Service, starService star.Service,
|
||||
features featuremgmt.FeatureToggles, dashboardService dashboards.DashboardService, accesscontrolService ac.Service, kvStore kvstore.KVStore, apiKeyService apikey.Service,
|
||||
license licensing.Licensing, authnService authn.Service, openFeature *featuremgmt.OpenFeatureService) navtree.Service {
|
||||
license licensing.Licensing, authnService authn.Service) navtree.Service {
|
||||
service := &ServiceImpl{
|
||||
cfg: cfg,
|
||||
log: log.New("navtree service"),
|
||||
@@ -70,7 +69,6 @@ func ProvideService(cfg *setting.Cfg, accessControl ac.AccessControl, pluginStor
|
||||
pluginSettings: pluginSettings,
|
||||
starService: starService,
|
||||
features: features,
|
||||
openFeature: openFeature,
|
||||
dashboardService: dashboardService,
|
||||
accesscontrolService: accesscontrolService,
|
||||
kvStore: kvStore,
|
||||
@@ -189,7 +187,7 @@ func (s *ServiceImpl) GetNavTree(c *contextmodel.ReqContext, prefs *pref.Prefere
|
||||
treeRoot.RemoveSectionByID(navtree.NavIDCfg)
|
||||
}
|
||||
|
||||
enabled := s.openFeature.Client.Boolean(ctx, featuremgmt.FlagPinNavItems, true, openfeature.TransactionContext(ctx))
|
||||
enabled := openfeature.GetApiInstance().GetClient().Boolean(ctx, featuremgmt.FlagPinNavItems, true, openfeature.TransactionContext(ctx))
|
||||
if enabled && c.IsSignedIn {
|
||||
treeRoot.AddSection(&navtree.NavLink{
|
||||
Text: "Bookmarks",
|
||||
|
||||
Reference in New Issue
Block a user