public/grafana
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

LibraryPanels: Remove unique name constraints (#113077)

Browse Source
This commit is contained in:
Ryan McKinley
2025-10-28 16:30:39 +03:00
committed by GitHub
parent 5670f1c34c
commit e1ddbda1bb
4 changed files with 509 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkg/services/libraryelements/libraryelements_patch_test.go
+4 -4
View File
@@ -332,7 +332,7 @@ func TestIntegration_PatchLibraryElement(t *testing.T) {
}
})
scenarioWithPanel(t, "When an admin tries to patch a library panel with a name that already exists, it should fail",
scenarioWithPanel(t, "When an admin tries to patch a library panel with a name that already exists, it should pass",
func(t *testing.T, sc scenarioContext) {
// nolint:staticcheck
command := getCreatePanelCommand(sc.folder.ID, sc.folder.UID, "Another Panel")
@@ -348,10 +348,10 @@ func TestIntegration_PatchLibraryElement(t *testing.T) {
sc.ctx.Req = web.SetURLParams(sc.ctx.Req, map[string]string{":uid": result.Result.UID})
sc.ctx.Req.Body = mockRequestBody(cmd)
resp = sc.service.patchHandler(sc.reqContext)
require.Equal(t, 400, resp.Status())
require.Equal(t, 200, resp.Status())
})
scenarioWithPanel(t, "When an admin tries to patch a library panel with a folder where a library panel with the same name already exists, it should fail",
scenarioWithPanel(t, "When an admin tries to patch a library panel with a folder where a library panel with the same name already exists, it should pass",
func(t *testing.T, sc scenarioContext) {
newFolder := &folder.Folder{
ID: 2,
@@ -375,7 +375,7 @@ func TestIntegration_PatchLibraryElement(t *testing.T) {
sc.ctx.Req = web.SetURLParams(sc.ctx.Req, map[string]string{":uid": sc.initialResult.Result.UID})
sc.ctx.Req.Body = mockRequestBody(cmd)
resp := sc.service.patchHandler(sc.reqContext)
require.Equal(t, 400, resp.Status())
require.Equal(t, 200, resp.Status())
})
scenarioWithPanel(t, "When an admin tries to patch a library panel in another org, it should fail",