public/grafana
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Alerting: Enable recording rules by default (#105603)

Browse Source
This commit is contained in:
Alexander Akhmetov
2025-06-02 10:56:05 +02:00
committed by GitHub
parent 4cde79e802
commit e256f2d5e2
26 changed files with 113 additions and 347 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkg/services/ngalert/schedule/recording_rule_test.go
-15
View File
@@ -177,13 +177,6 @@ func blankRecordingRuleForTests(ctx context.Context) *recordingRule {
}
func TestRecordingRule_Integration(t *testing.T) {
t.Run("with prometheus writer", func(t *testing.T) {
writeTarget := writer.NewTestRemoteWriteTarget(t)
defer writeTarget.Close()
writerReg := prometheus.NewPedanticRegistry()
writer := setupPrometheusWriter(t, writeTarget, writerReg)
testRecordingRule_Integration(t, writeTarget, writer, writerReg, "")
})
t.Run("with datasource writer", func(t *testing.T) {
writeTarget := writer.NewTestRemoteWriteTarget(t)
defer writeTarget.Close()
@@ -798,14 +791,6 @@ func withQueryForHealth(health string) models.AlertRuleMutator {
}
}
func setupPrometheusWriter(t *testing.T, target *writer.TestRemoteWriteTarget, reg prometheus.Registerer) *writer.PrometheusWriter {
provider := testClientProvider{}
m := metrics.NewNGAlert(reg)
wr, err := writer.NewPrometheusWriterWithSettings(target.ClientSettings(), provider, clock.NewMock(), log.NewNopLogger(), m.GetRemoteWriterMetrics())
require.NoError(t, err)
return wr
}
func setupDatasourceWriter(t *testing.T, target *writer.TestRemoteWriteTarget, reg prometheus.Registerer, dsUID string) *writer.DatasourceWriter {
provider := testClientProvider{}
m := metrics.NewNGAlert(reg)