From e4265fe39caf075bc8e15bbe51128bd5b1a9b7a5 Mon Sep 17 00:00:00 2001 From: Alejandro Fraenkel Date: Tue, 13 Jan 2026 17:09:16 +0100 Subject: [PATCH] fix(alerting): remove obsolete notification templates tab checks from ContactPoints tests - Remove test code checking for Notification Templates tab (lines 282-288 and 494-497) - Templates are now a separate page in sidebar navigation, not a tab within Contact Points - Tests should only verify contact points permissions, not templates --- .../contact-points/ContactPoints.test.tsx | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/public/app/features/alerting/unified/components/contact-points/ContactPoints.test.tsx b/public/app/features/alerting/unified/components/contact-points/ContactPoints.test.tsx index a624a00a83d..fa333b21e7a 100644 --- a/public/app/features/alerting/unified/components/contact-points/ContactPoints.test.tsx +++ b/public/app/features/alerting/unified/components/contact-points/ContactPoints.test.tsx @@ -278,14 +278,6 @@ describe('contact points', () => { // there should be view buttons though - one for provisioned, and one for the un-editable contact point const viewButtons = screen.getAllByRole('link', { name: /^view$/i }); expect(viewButtons).toHaveLength(2); - - // check buttons in Notification Templates - const notificationTemplatesTab = screen.getByRole('tab', { name: 'Notification Templates' }); - await user.click(notificationTemplatesTab); - expect(screen.getByRole('link', { name: 'Add notification template group' })).toHaveAttribute( - 'aria-disabled', - 'true' - ); }); it('allows deleting when not disabled', async () => { @@ -490,11 +482,6 @@ describe('contact points', () => { const viewButton = screen.getByRole('link', { name: /^view$/i }); expect(viewButton).toBeInTheDocument(); expect(viewButton).toBeEnabled(); - - // check buttons in Notification Templates - const notificationTemplatesTab = screen.getByRole('tab', { name: 'Notification Templates' }); - await user.click(notificationTemplatesTab); - expect(screen.queryByRole('link', { name: 'Add notification template group' })).not.toBeInTheDocument(); }); });