From e4c9e573cba882827c5e1e1e590e0ce61b91d7a0 Mon Sep 17 00:00:00 2001 From: "Grot (@grafanabot)" <43478413+grafanabot@users.noreply.github.com> Date: Wed, 6 Jul 2022 09:04:53 +0100 Subject: [PATCH] Traces: Trace to logs fix (#51053) (#51778) * Fix to set isSplunkDS * Remove comment * Updated betterer.results (cherry picked from commit 2970c6db375e258a6fbf129c21b7210af248d40c) Co-authored-by: Joey Tawadrous <90795735+joey-grafana@users.noreply.github.com> --- public/app/features/explore/TraceView/createSpanLink.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/public/app/features/explore/TraceView/createSpanLink.tsx b/public/app/features/explore/TraceView/createSpanLink.tsx index f9b009dff03..18bf3a87d0d 100644 --- a/public/app/features/explore/TraceView/createSpanLink.tsx +++ b/public/app/features/explore/TraceView/createSpanLink.tsx @@ -87,10 +87,10 @@ function legacyCreateSpanLinkFactory( createFocusSpanLink?: (traceId: string, spanId: string) => LinkModel ) { let logsDataSourceSettings: DataSourceInstanceSettings | undefined; - const isSplunkDS = logsDataSourceSettings?.type === 'grafana-splunk-datasource'; if (traceToLogsOptions?.datasourceUid) { logsDataSourceSettings = getDatasourceSrv().getInstanceSettings(traceToLogsOptions.datasourceUid); } + const isSplunkDS = logsDataSourceSettings?.type === 'grafana-splunk-datasource'; let metricsDataSourceSettings: DataSourceInstanceSettings | undefined; if (traceToMetricsOptions?.datasourceUid) {