From e51a8c25d1bb83d59b4207b57dc7f33c0c3f84b3 Mon Sep 17 00:00:00 2001
From: Laura Benz <48948963+L-M-K-B@users.noreply.github.com>
Date: Fri, 22 Mar 2024 14:26:09 +0100
Subject: [PATCH] ReturnToPrevious: Fix e2e test (#84938)

refactor: remove some waiting for elements that seem to have been removed
---
 e2e/various-suite/return-to-previous.spec.ts | 14 +-------------
 1 file changed, 1 insertion(+), 13 deletions(-)

diff --git a/e2e/various-suite/return-to-previous.spec.ts b/e2e/various-suite/return-to-previous.spec.ts
index 82b87367b6e..bc47efc5c57 100644
--- a/e2e/various-suite/return-to-previous.spec.ts
+++ b/e2e/various-suite/return-to-previous.spec.ts
@@ -1,6 +1,6 @@
 import { e2e } from '../utils';
 
-describe.skip('ReturnToPrevious button', () => {
+describe('ReturnToPrevious button', () => {
   beforeEach(() => {
     e2e.flows.login(Cypress.env('USERNAME'), Cypress.env('PASSWORD'));
     cy.window().then((win) => {
@@ -16,9 +16,6 @@ describe.skip('ReturnToPrevious button', () => {
   });
 
   it('should appear when changing context and go back to alert rule when clicking "Back"', () => {
-    // make sure the dashboard finished loading
-    cy.get('button[aria-label*="BarChart - Label Rotation & Skipping"]').should('be.visible');
-
     // check whether all elements of RTP are available
     e2e.components.ReturnToPrevious.buttonGroup().should('be.visible');
     e2e.components.ReturnToPrevious.dismissButton().should('be.visible');
@@ -42,9 +39,6 @@ describe.skip('ReturnToPrevious button', () => {
   it('should not persist when going back to the alert rule details view', () => {
     e2e.components.ReturnToPrevious.buttonGroup().should('be.visible');
 
-    // make sure the dashboard finished loading
-    cy.get('button[aria-label*="BarChart - Label Rotation & Skipping"]').should('be.visible');
-
     cy.visit('/alerting/list');
     e2e.components.AlertRules.groupToggle().first().click();
     cy.get('a[title="View"]').click();
@@ -52,9 +46,6 @@ describe.skip('ReturnToPrevious button', () => {
   });
 
   it('should override the button label and change the href when user changes alert rules', () => {
-    // make sure the dashboard finished loading
-    cy.get('button[aria-label*="BarChart - Label Rotation & Skipping"]').should('be.visible');
-
     e2e.components.ReturnToPrevious.backButton()
       .find('span')
       .contains('Back to e2e-ReturnToPrevious-test')
@@ -67,9 +58,6 @@ describe.skip('ReturnToPrevious button', () => {
     cy.url().as('alertRule2Url');
     cy.get('a').contains('View panel').click();
 
-    // make sure the dashboard finished loading
-    cy.get('button[aria-label*="BarChart - Label Rotation & Skipping"]').should('be.visible');
-
     e2e.components.ReturnToPrevious.backButton()
       .find('span')
       .contains('Back to e2e-ReturnToPrevious-test-2')