Tests: Require GrafanaOpts when creating Grafana dir (#97825)
I don't see a reason to accept a variable amount here, as we never use it. The only use I can see is optionally including the opts, which isn't necessary and only complicates matters when an empty struct would do just as well: the options are all created to be assumed zero-values already, in case a test doesn't need that option set.
This commit is contained in:
@@ -47,7 +47,9 @@ func TestIntegrationIndexView(t *testing.T) {
|
||||
})
|
||||
|
||||
t.Run("CSP disabled", func(t *testing.T) {
|
||||
grafDir, cfgPath := testinfra.CreateGrafDir(t)
|
||||
grafDir, cfgPath := testinfra.CreateGrafDir(t, testinfra.GrafanaOpts{
|
||||
EnableCSP: false,
|
||||
})
|
||||
addr, _ := testinfra.StartGrafana(t, grafDir, cfgPath)
|
||||
|
||||
// nolint:bodyclose
|
||||
|
||||
Reference in New Issue
Block a user