From e7d7ed5406d7eecb9fe8ddfe5a30149526b55ff4 Mon Sep 17 00:00:00 2001 From: Jack Westbrook Date: Tue, 3 Sep 2024 12:43:13 +0200 Subject: [PATCH] Chore: Remove side-effect import from app (#92650) * chore(frontend): remove stray side-effect features import that brings the whole jungle * chore(app): delete features/all.ts and its friends * chore(codeowners): remove public/app/features/all.ts from file --- .github/CODEOWNERS | 1 - public/app/app.ts | 2 -- public/app/features/all.ts | 2 -- public/app/features/dashboard/index.ts | 7 ------- public/app/features/plugins/all.ts | 1 - 5 files changed, 13 deletions(-) delete mode 100644 public/app/features/all.ts delete mode 100644 public/app/features/dashboard/index.ts delete mode 100644 public/app/features/plugins/all.ts diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 5bc3cab07ce..eeb90d4556a 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -403,7 +403,6 @@ playwright.config.ts @grafana/plugins-platform-frontend /public/app/core/components/TimelineChart/ @grafana/dataviz-squad /public/app/core/components/Form/ @grafana/grafana-frontend-platform /public/app/core/history/ @grafana/explore-squad -/public/app/features/all.ts @grafana/grafana-frontend-platform /public/app/features/admin/ @grafana/identity-access-team # Temp owners until Enterprise team takes over diff --git a/public/app/app.ts b/public/app/app.ts index 6e6141e0d86..bc5dd608787 100644 --- a/public/app/app.ts +++ b/public/app/app.ts @@ -6,8 +6,6 @@ import 'file-saver'; import 'jquery'; import 'vendor/bootstrap/bootstrap'; -import 'app/features/all'; - import _ from 'lodash'; // eslint-disable-line lodash/import-scope import { createElement } from 'react'; import { createRoot } from 'react-dom/client'; diff --git a/public/app/features/all.ts b/public/app/features/all.ts deleted file mode 100644 index b25b7b50951..00000000000 --- a/public/app/features/all.ts +++ /dev/null @@ -1,2 +0,0 @@ -import './plugins/all'; -import './dashboard'; diff --git a/public/app/features/dashboard/index.ts b/public/app/features/dashboard/index.ts deleted file mode 100644 index 12c86883b58..00000000000 --- a/public/app/features/dashboard/index.ts +++ /dev/null @@ -1,7 +0,0 @@ -// Services -import './services/DashboardLoaderSrv'; -import './services/DashboardSrv'; -// Components -import './components/DashExportModal'; -import './components/DashNav'; -import './components/DashboardSettings'; diff --git a/public/app/features/plugins/all.ts b/public/app/features/plugins/all.ts deleted file mode 100644 index fe460be0708..00000000000 --- a/public/app/features/plugins/all.ts +++ /dev/null @@ -1 +0,0 @@ -import './datasource_srv';