From e942a3d99d94173b5a2795b71f776e66c3c7a1c6 Mon Sep 17 00:00:00 2001
From: Ashley Harrison <ashley.harrison@grafana.com>
Date: Tue, 4 Oct 2022 12:54:14 +0100
Subject: [PATCH] enable jsx-a11y/no-autofocus (#56288)

---
 .eslintrc                                                  | 7 ++++++-
 .../grafana-ui/src/components/Segment/SegmentInput.tsx     | 2 ++
 public/app/features/search/components/DashboardSearch.tsx  | 1 -
 .../features/search/components/DashboardSearchModal.tsx    | 1 -
 4 files changed, 8 insertions(+), 3 deletions(-)

diff --git a/.eslintrc b/.eslintrc
index c70c9f3ebf8..40b042e0a15 100644
--- a/.eslintrc
+++ b/.eslintrc
@@ -101,7 +101,12 @@
         "jsx-a11y/media-has-caption": "error",
         "jsx-a11y/mouse-events-have-key-events": "off",
         "jsx-a11y/no-access-key": "error",
-        "jsx-a11y/no-autofocus": "off",
+        "jsx-a11y/no-autofocus": [
+          "error",
+          {
+            "ignoreNonDOM": true
+          }
+        ],
         "jsx-a11y/no-distracting-elements": "error",
         "jsx-a11y/no-interactive-element-to-noninteractive-role": "error",
         "jsx-a11y/no-noninteractive-element-interactions": [
diff --git a/packages/grafana-ui/src/components/Segment/SegmentInput.tsx b/packages/grafana-ui/src/components/Segment/SegmentInput.tsx
index 5e3e4704be6..acfaef89d9d 100644
--- a/packages/grafana-ui/src/components/Segment/SegmentInput.tsx
+++ b/packages/grafana-ui/src/components/Segment/SegmentInput.tsx
@@ -74,6 +74,8 @@ export function SegmentInput<T>({
     <input
       {...rest}
       ref={ref}
+      // this needs to autofocus, but it's ok as it's only rendered by choice
+      // eslint-disable-next-line jsx-a11y/no-autofocus
       autoFocus
       className={cx(`gf-form gf-form-input`, inputWidthStyle)}
       value={value}
diff --git a/public/app/features/search/components/DashboardSearch.tsx b/public/app/features/search/components/DashboardSearch.tsx
index 7e431628bde..48d55e8f193 100644
--- a/public/app/features/search/components/DashboardSearch.tsx
+++ b/public/app/features/search/components/DashboardSearch.tsx
@@ -41,7 +41,6 @@ export function DashboardSearch({}: Props) {
               onKeyDown={onKeyDown}
               spellCheck={false}
               className={styles.input}
-              autoFocus
             />
           </div>
 
diff --git a/public/app/features/search/components/DashboardSearchModal.tsx b/public/app/features/search/components/DashboardSearchModal.tsx
index 67b7736586d..298c37c436e 100644
--- a/public/app/features/search/components/DashboardSearchModal.tsx
+++ b/public/app/features/search/components/DashboardSearchModal.tsx
@@ -70,7 +70,6 @@ export function DashboardSearchModal({ isOpen }: Props) {
                   tabIndex={0}
                   spellCheck={false}
                   className={styles.input}
-                  autoFocus
                 />
               </div>