Prometheus: Support utf8 metrics and labels in scopes (#99015)

* support utf8 in scopes

* separate the utf8 tests

* remove redundant test after enabling utf8 validation in prometheus
This commit is contained in:
ismail simsek
2025-01-16 18:11:44 +02:00
committed by GitHub
parent c0b3932168
commit e96b5a68c4
3 changed files with 141 additions and 11 deletions
@@ -785,15 +785,6 @@ func TestIntegrationInsertAlertRules(t *testing.T) {
require.ErrorIs(t, err, models.ErrAlertRuleFailedValidation)
require.ErrorContains(t, err, "metric name for recording rule must be a valid utf8 string")
})
t.Run("invalid metric name", func(t *testing.T) {
invalidMetric := "with-dashes"
invalidRule := recordingRulesGen.Generate()
invalidRule.Record.Metric = invalidMetric
_, err := store.InsertAlertRules(context.Background(), []models.AlertRule{invalidRule})
require.ErrorIs(t, err, models.ErrAlertRuleFailedValidation)
require.ErrorContains(t, err, "metric name for recording rule must be a valid Prometheus metric name")
})
})
t.Run("clears fields that should not exist on recording rules", func(t *testing.T) {